Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: webrtc/modules/video_coding/nack_module_unittest.cc

Issue 1972123002: Nack count returned on OnReceivedPacket. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Feedback fix. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/video_coding/nack_module.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/video_coding/nack_module_unittest.cc
diff --git a/webrtc/modules/video_coding/nack_module_unittest.cc b/webrtc/modules/video_coding/nack_module_unittest.cc
index 3870742016a0a39120dcdb3375536d6d439c8646..9c2eb4ac0c3f0706295a3a89cef58243c47294c8 100644
--- a/webrtc/modules/video_coding/nack_module_unittest.cc
+++ b/webrtc/modules/video_coding/nack_module_unittest.cc
@@ -290,4 +290,28 @@ TEST_F(TestNackModule, ClearUpToWrap) {
EXPECT_EQ(0, sent_nacks_[0]);
}
+TEST_F(TestNackModule, PacketNackCount) {
+ VCMPacket packet;
+ packet.seqNum = 0;
+ EXPECT_EQ(0, nack_module_.OnReceivedPacket(packet));
+ packet.seqNum = 2;
+ EXPECT_EQ(0, nack_module_.OnReceivedPacket(packet));
+ packet.seqNum = 1;
+ EXPECT_EQ(1, nack_module_.OnReceivedPacket(packet));
+
+ sent_nacks_.clear();
+ nack_module_.UpdateRtt(100);
+ packet.seqNum = 5;
+ EXPECT_EQ(0, nack_module_.OnReceivedPacket(packet));
+ clock_->AdvanceTimeMilliseconds(100);
+ nack_module_.Process();
+ clock_->AdvanceTimeMilliseconds(100);
+ nack_module_.Process();
+ packet.seqNum = 3;
+ EXPECT_EQ(3, nack_module_.OnReceivedPacket(packet));
+ packet.seqNum = 4;
+ EXPECT_EQ(3, nack_module_.OnReceivedPacket(packet));
+ EXPECT_EQ(0, nack_module_.OnReceivedPacket(packet));
+}
+
} // namespace webrtc
« no previous file with comments | « webrtc/modules/video_coding/nack_module.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698