Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: webrtc/video/vie_encoder.h

Issue 1972083002: Move logic for calculating needed bitrate overhead used by NACK and FEC to VideoSender. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed Åsas comments. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/video/video_send_stream.cc ('k') | webrtc/video/vie_encoder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/vie_encoder.h
diff --git a/webrtc/video/vie_encoder.h b/webrtc/video/vie_encoder.h
index 212962348ad7a110c24a3060437fe7c320e1531e..4372bd11c905615def67adc198d51b6438619331 100644
--- a/webrtc/video/vie_encoder.h
+++ b/webrtc/video/vie_encoder.h
@@ -84,13 +84,11 @@ class ViEEncoder : public VideoEncoderRateObserver,
void EncodeVideoFrame(const VideoFrame& video_frame);
void SendKeyFrame();
- uint32_t LastObservedBitrateBps() const;
- // Loss protection. Must be called before SetEncoder() to have max packet size
- // updated according to protection.
- // TODO(pbos): Set protection method on construction.
- void SetProtectionMethod(bool nack, bool fec);
-
// Implements VideoEncoderRateObserver.
+ // TODO(perkj): Refactor VideoEncoderRateObserver. This is only used for
+ // stats. The stats should be set in VideoSendStream instead.
+ // |bitrate_bps| is the target bitrate and |framerate| is the input frame
+ // rate so it has nothing to do with the actual encoder.
void OnSetRates(uint32_t bitrate_bps, int framerate) override;
// Implements EncodedImageCallback.
« no previous file with comments | « webrtc/video/video_send_stream.cc ('k') | webrtc/video/vie_encoder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698