webrtc/modules/video_coding/video_coding_impl.cc - Issue 1972083002: Move logic for calculating needed bitrate overhead used by NACK and FEC to VideoSender.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/video_coding_impl.cc

Issue 1972083002: Move logic for calculating needed bitrate overhead used by NACK and FEC to VideoSender. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Addressed Åsas comments. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/video_coding/video_coding_impl.cc

diff --git a/webrtc/modules/video_coding/video_coding_impl.cc b/webrtc/modules/video_coding/video_coding_impl.cc

index 72bcc9a059448bc3760402200e1aaf28ca0b051d..bb81ba9f9efe3c976bf2c9d79901077ced39d506 100644

--- a/webrtc/modules/video_coding/video_coding_impl.cc

+++ b/webrtc/modules/video_coding/video_coding_impl.cc

@@ -136,8 +136,6 @@ class VideoCodingModuleImpl : public VideoCodingModule {

int32_t SetVideoProtection(VCMVideoProtection videoProtection,

bool enable) override {

// TODO(pbos): Remove enable from receive-side protection modes as well.

- if (enable)

- sender_.SetVideoProtection(videoProtection);

return receiver_.SetVideoProtection(videoProtection, enable);

}

« no previous file with comments | « webrtc/modules/video_coding/video_coding_impl.h ('k') | webrtc/modules/video_coding/video_sender.cc » ('j') | no next file with comments »