webrtc/video/send_statistics_proxy.cc - Issue 1972083002: Move logic for calculating needed bitrate overhead used by NACK and FEC to VideoSender.

Unified Diff: webrtc/video/send_statistics_proxy.cc

Issue 1972083002: Move logic for calculating needed bitrate overhead used by NACK and FEC to VideoSender. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Addressed review comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/video_coding/protection_bitrate_calculator_unittest.cc ('K') | « webrtc/video/send_statistics_proxy.h ('k') | webrtc/video/video_send_stream.h » ('j') | webrtc/video/video_send_stream.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/video/send_statistics_proxy.cc

diff --git a/webrtc/video/send_statistics_proxy.cc b/webrtc/video/send_statistics_proxy.cc

index d8c11a8c3588ee061bfcca9189fe531709f6f066..18d9c22b503d9906a73a67c11f452195b4e66236 100644

--- a/webrtc/video/send_statistics_proxy.cc

+++ b/webrtc/video/send_statistics_proxy.cc

@@ -513,6 +513,11 @@ void SendStatisticsProxy::OnSendEncodedImage(

static_cast<int>(encoded_image._encodedHeight));

}

+float SendStatisticsProxy::GetSendFrameRate() {

+ rtc::CritScope lock(&crit_);

+ return uma_container_->sent_frame_rate_tracker_.ComputeRateForInterval(1000);

stefan-webrtc 2016/06/02 07:42:37 It seems a bit weird to me that we're getting the

perkj_webrtc 2016/06/02 10:16:20 sure- would it be nice if pc.GetStats, uma and int

åsapersson 2016/06/02 11:11:40 Maybe it is better to return stats_.encode_frame_r

perkj_webrtc 2016/06/02 11:33:20 Done.

void SendStatisticsProxy::OnIncomingFrame(int width, int height) {

rtc::CritScope lock(&crit_);

uma_container_->input_frame_rate_tracker_.AddSamples(1);