webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc - Issue 1972083002: Move logic for calculating needed bitrate overhead used by NACK and FEC to VideoSender.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc

Issue 1972083002: Move logic for calculating needed bitrate overhead used by NACK and FEC to VideoSender. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Removed video_sender_unittest for now. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc

diff --git a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc

index f38ef783067eb478b27d40837c34ac36f1b2bc43..6a5371e90ce7fd7d3b61618d9d8e8de966b6d8f8 100644

--- a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc

+++ b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_single_stream.cc

@@ -54,7 +54,6 @@ struct RemoteBitrateEstimatorSingleStream::Detector {

crit_sect_(CriticalSectionWrapper::CreateCriticalSection()),

last_process_time_(-1),

process_interval_ms_(kProcessIntervalMs) {

- assert(observer_);

stefan-webrtc 2016/05/19 12:52:39 Why?

perkj_webrtc 2016/06/01 20:55:23 reverted. Needed by new VideoSendStreamTests that

LOG(LS_INFO) << "RemoteBitrateEstimatorSingleStream: Instantiating.";

}

« no previous file with comments | « webrtc/modules/modules.gyp ('k') | webrtc/modules/video_coding/BUILD.gn » ('j') | webrtc/modules/video_coding/protection_bitrate_calculator.h » ('J')