Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Side by Side Diff: webrtc/modules/video_coding/include/video_coding.h

Issue 1972083002: Move logic for calculating needed bitrate overhead used by NACK and FEC to VideoSender. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed Åsas comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/video_coding/BUILD.gn ('k') | webrtc/modules/video_coding/media_optimization.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 // Input: 181 // Input:
182 // - rtt : Current round-trip time in ms. 182 // - rtt : Current round-trip time in ms.
183 // with the most amount available bandwidth in 183 // with the most amount available bandwidth in
184 // a conference 184 // a conference
185 // scenario 185 // scenario
186 // 186 //
187 // Return value : VCM_OK, on success. 187 // Return value : VCM_OK, on success.
188 // < 0, on error. 188 // < 0, on error.
189 virtual int32_t SetReceiveChannelParameters(int64_t rtt) = 0; 189 virtual int32_t SetReceiveChannelParameters(int64_t rtt) = 0;
190 190
191 // Deprecated: This method currently does not have any effect.
191 // Register a video protection callback which will be called to deliver 192 // Register a video protection callback which will be called to deliver
192 // the requested FEC rate and NACK status (on/off). 193 // the requested FEC rate and NACK status (on/off).
193 // 194 // TODO(perkj): Remove once no projects use it.
194 // Input:
195 // - protection : The callback object to register.
196 //
197 // Return value : VCM_OK, on success.
198 // < 0, on error.
199 virtual int32_t RegisterProtectionCallback( 195 virtual int32_t RegisterProtectionCallback(
200 VCMProtectionCallback* protection) = 0; 196 VCMProtectionCallback* protection) = 0;
201 197
202 // Enable or disable a video protection method. 198 // Enable or disable a video protection method.
203 // 199 //
204 // Input: 200 // Input:
205 // - videoProtection : The method to enable or disable. 201 // - videoProtection : The method to enable or disable.
206 // - enable : True if the method should be enabled, false if 202 // - enable : True if the method should be enabled, false if
207 // it should be disabled. 203 // it should be disabled.
208 // 204 //
(...skipping 278 matching lines...) Expand 10 before | Expand all | Expand 10 after
487 483
488 virtual void RegisterPostEncodeImageCallback( 484 virtual void RegisterPostEncodeImageCallback(
489 EncodedImageCallback* post_encode_callback) = 0; 485 EncodedImageCallback* post_encode_callback) = 0;
490 // Releases pending decode calls, permitting faster thread shutdown. 486 // Releases pending decode calls, permitting faster thread shutdown.
491 virtual void TriggerDecoderShutdown() = 0; 487 virtual void TriggerDecoderShutdown() = 0;
492 }; 488 };
493 489
494 } // namespace webrtc 490 } // namespace webrtc
495 491
496 #endif // WEBRTC_MODULES_VIDEO_CODING_INCLUDE_VIDEO_CODING_H_ 492 #endif // WEBRTC_MODULES_VIDEO_CODING_INCLUDE_VIDEO_CODING_H_
OLDNEW
« no previous file with comments | « webrtc/modules/video_coding/BUILD.gn ('k') | webrtc/modules/video_coding/media_optimization.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698