Revert of Implement RTCConfiguration.iceCandidatePoolSize.

Revert of Implement RTCConfiguration.iceCandidatePoolSize. (patchset #7 id:120001 of https://codereview.webrtc.org/1956453003/ )

Reason for revert:
Breaks remoting_unittests. They defined their own operator== which conflicts with this one.

I'll remove the operator== in a roll CL. But until it's approved, I'm reverting this so the FYI bots will pass.

Original issue's description:
> Implement RTCConfiguration.iceCandidatePoolSize.
>
> It works by creating pooled PortAllocatorSessions which can be picked up
> by a P2PTransportChannel when needed (after a local description is set).
>
> This can optimize candidate gathering time when there is some time between
> creating a PeerConnection and setting a local description.
>
> R=pthatcher@webrtc.org
>
> Committed: https://chromium.googlesource.com/external/webrtc/+/48e9d05f510b1616c81303944008f75825971802

TBR=pthatcher@webrtc.org,honghaiz@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Committed: https://crrev.com/c55fb30649db2656546739ed6c2d23497424e6fd
Cr-Commit-Position: refs/heads/master@{#12709}

[Taylor Brandstetter, 2016-05-12 19:43:38]

Created Revert of Implement RTCConfiguration.iceCandidatePoolSize.

[commit-bot: I haz the power, 2016-05-12 19:43:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1972043004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1972043004/1

[commit-bot: I haz the power, 2016-05-12 19:44:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 19:44:01]

Failed to apply patch for webrtc/p2p/p2p.gyp:
While running git apply --index -3 -p1;
  error: patch failed: webrtc/p2p/p2p.gyp:177
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: webrtc/p2p/p2p.gyp: patch does not apply

Patch:       webrtc/p2p/p2p.gyp
Index: webrtc/p2p/p2p.gyp
diff --git a/webrtc/p2p/p2p.gyp b/webrtc/p2p/p2p.gyp
index
537c5d186fdfc996952f0a51574c2ce0e0480a79..50941c86827fcbc65317177f4c13ee91f3941cbd
100644
--- a/webrtc/p2p/p2p.gyp
+++ b/webrtc/p2p/p2p.gyp
@@ -158,11 +158,9 @@
           'direct_dependent_settings': {
             'sources': [
               'base/dtlstransportchannel_unittest.cc',
-              'base/fakeportallocator.h',
               'base/faketransportcontroller.h',
               'base/p2ptransportchannel_unittest.cc',
               'base/port_unittest.cc',
-              'base/portallocator_unittest.cc',
               'base/pseudotcp_unittest.cc',
               'base/relayport_unittest.cc',
               'base/relayserver_unittest.cc',
@@ -177,7 +175,8 @@
               'base/transportcontroller_unittest.cc',
               'base/transportdescriptionfactory_unittest.cc',
               'base/turnport_unittest.cc',
-              'client/basicportallocator_unittest.cc',
+              'client/fakeportallocator.h',
+              'client/portallocator_unittest.cc',
               'stunprober/stunprober_unittest.cc',
             ],
             'conditions': [

[Taylor Brandstetter, 2016-05-12 19:51:21]

The CQ bit was checked by deadbeef@webrtc.org

[commit-bot: I haz the power, 2016-05-12 19:51:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1972043004/310001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1972043004/310001

[commit-bot: I haz the power, 2016-05-12 19:51:42]

Description was changed from

==========
Revert of Implement RTCConfiguration.iceCandidatePoolSize. (patchset #7
id:120001 of https://codereview.webrtc.org/1956453003/ )

Reason for revert:
Breaks remoting_unittests. They defined their own operator== which conflicts
with this one.

I'll remove the operator== in a roll CL. But until it's approved, I'm reverting
this so the FYI bots will pass.

Original issue's description:
> Implement RTCConfiguration.iceCandidatePoolSize.
> 
> It works by creating pooled PortAllocatorSessions which can be picked up
> by a P2PTransportChannel when needed (after a local description is set).
> 
> This can optimize candidate gathering time when there is some time between
> creating a PeerConnection and setting a local description.
> 
> R=pthatcher@webrtc.org
> 
> Committed:
https://chromium.googlesource.com/external/webrtc/+/48e9d05f510b1616c81303944...

TBR=pthatcher@webrtc.org,honghaiz@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

to

==========
Revert of Implement RTCConfiguration.iceCandidatePoolSize. (patchset #7
id:120001 of https://codereview.webrtc.org/1956453003/ )

Reason for revert:
Breaks remoting_unittests. They defined their own operator== which conflicts
with this one.

I'll remove the operator== in a roll CL. But until it's approved, I'm reverting
this so the FYI bots will pass.

Original issue's description:
> Implement RTCConfiguration.iceCandidatePoolSize.
> 
> It works by creating pooled PortAllocatorSessions which can be picked up
> by a P2PTransportChannel when needed (after a local description is set).
> 
> This can optimize candidate gathering time when there is some time between
> creating a PeerConnection and setting a local description.
> 
> R=pthatcher@webrtc.org
> 
> Committed:
https://chromium.googlesource.com/external/webrtc/+/48e9d05f510b1616c81303944...

TBR=pthatcher@webrtc.org,honghaiz@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

[commit-bot: I haz the power, 2016-05-12 19:51:43]

Committed patchset #2 (id:310001)

[commit-bot: I haz the power, 2016-05-12 19:51:52]

Description was changed from

==========
Revert of Implement RTCConfiguration.iceCandidatePoolSize. (patchset #7
id:120001 of https://codereview.webrtc.org/1956453003/ )

Reason for revert:
Breaks remoting_unittests. They defined their own operator== which conflicts
with this one.

I'll remove the operator== in a roll CL. But until it's approved, I'm reverting
this so the FYI bots will pass.

Original issue's description:
> Implement RTCConfiguration.iceCandidatePoolSize.
> 
> It works by creating pooled PortAllocatorSessions which can be picked up
> by a P2PTransportChannel when needed (after a local description is set).
> 
> This can optimize candidate gathering time when there is some time between
> creating a PeerConnection and setting a local description.
> 
> R=pthatcher@webrtc.org
> 
> Committed:
https://chromium.googlesource.com/external/webrtc/+/48e9d05f510b1616c81303944...

TBR=pthatcher@webrtc.org,honghaiz@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

to

==========
Revert of Implement RTCConfiguration.iceCandidatePoolSize. (patchset #7
id:120001 of https://codereview.webrtc.org/1956453003/ )

Reason for revert:
Breaks remoting_unittests. They defined their own operator== which conflicts
with this one.

I'll remove the operator== in a roll CL. But until it's approved, I'm reverting
this so the FYI bots will pass.

Original issue's description:
> Implement RTCConfiguration.iceCandidatePoolSize.
>
> It works by creating pooled PortAllocatorSessions which can be picked up
> by a P2PTransportChannel when needed (after a local description is set).
>
> This can optimize candidate gathering time when there is some time between
> creating a PeerConnection and setting a local description.
>
> R=pthatcher@webrtc.org
>
> Committed:
https://chromium.googlesource.com/external/webrtc/+/48e9d05f510b1616c81303944...

TBR=pthatcher@webrtc.org,honghaiz@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Committed: https://crrev.com/c55fb30649db2656546739ed6c2d23497424e6fd
Cr-Commit-Position: refs/heads/master@{#12709}
==========

[commit-bot: I haz the power, 2016-05-12 19:51:53]

Patchset 2 (id:??) landed as
https://crrev.com/c55fb30649db2656546739ed6c2d23497424e6fd
Cr-Commit-Position: refs/heads/master@{#12709}