Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Side by Side Diff: webrtc/sdk/objc/Framework/UnitTests/RTCConfigurationTest.mm

Issue 1971563002: Add config continualGatheringPolicy to the IOS RTCConfiguration. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: address comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 23 matching lines...) Expand all
34 config.iceTransportPolicy = RTCIceTransportPolicyRelay; 34 config.iceTransportPolicy = RTCIceTransportPolicyRelay;
35 config.bundlePolicy = RTCBundlePolicyMaxBundle; 35 config.bundlePolicy = RTCBundlePolicyMaxBundle;
36 config.rtcpMuxPolicy = RTCRtcpMuxPolicyNegotiate; 36 config.rtcpMuxPolicy = RTCRtcpMuxPolicyNegotiate;
37 config.tcpCandidatePolicy = RTCTcpCandidatePolicyDisabled; 37 config.tcpCandidatePolicy = RTCTcpCandidatePolicyDisabled;
38 const int maxPackets = 60; 38 const int maxPackets = 60;
39 const int timeout = 1; 39 const int timeout = 1;
40 const int interval = 2; 40 const int interval = 2;
41 config.audioJitterBufferMaxPackets = maxPackets; 41 config.audioJitterBufferMaxPackets = maxPackets;
42 config.iceConnectionReceivingTimeout = timeout; 42 config.iceConnectionReceivingTimeout = timeout;
43 config.iceBackupCandidatePairPingInterval = interval; 43 config.iceBackupCandidatePairPingInterval = interval;
44 config.continualGatheringPolicy = RTCGatherContinually;
44 45
45 webrtc::PeerConnectionInterface::RTCConfiguration nativeConfig = 46 webrtc::PeerConnectionInterface::RTCConfiguration nativeConfig =
46 config.nativeConfiguration; 47 config.nativeConfiguration;
47 EXPECT_EQ(1u, nativeConfig.servers.size()); 48 EXPECT_EQ(1u, nativeConfig.servers.size());
48 webrtc::PeerConnectionInterface::IceServer nativeServer = 49 webrtc::PeerConnectionInterface::IceServer nativeServer =
49 nativeConfig.servers.front(); 50 nativeConfig.servers.front();
50 EXPECT_EQ(1u, nativeServer.urls.size()); 51 EXPECT_EQ(1u, nativeServer.urls.size());
51 EXPECT_EQ("stun:stun1.example.net", nativeServer.urls.front()); 52 EXPECT_EQ("stun:stun1.example.net", nativeServer.urls.front());
52 53
53 EXPECT_EQ(webrtc::PeerConnectionInterface::kRelay, nativeConfig.type); 54 EXPECT_EQ(webrtc::PeerConnectionInterface::kRelay, nativeConfig.type);
54 EXPECT_EQ(webrtc::PeerConnectionInterface::kBundlePolicyMaxBundle, 55 EXPECT_EQ(webrtc::PeerConnectionInterface::kBundlePolicyMaxBundle,
55 nativeConfig.bundle_policy); 56 nativeConfig.bundle_policy);
56 EXPECT_EQ(webrtc::PeerConnectionInterface::kRtcpMuxPolicyNegotiate, 57 EXPECT_EQ(webrtc::PeerConnectionInterface::kRtcpMuxPolicyNegotiate,
57 nativeConfig.rtcp_mux_policy); 58 nativeConfig.rtcp_mux_policy);
58 EXPECT_EQ(webrtc::PeerConnectionInterface::kTcpCandidatePolicyDisabled, 59 EXPECT_EQ(webrtc::PeerConnectionInterface::kTcpCandidatePolicyDisabled,
59 nativeConfig.tcp_candidate_policy); 60 nativeConfig.tcp_candidate_policy);
60 EXPECT_EQ(maxPackets, nativeConfig.audio_jitter_buffer_max_packets); 61 EXPECT_EQ(maxPackets, nativeConfig.audio_jitter_buffer_max_packets);
61 EXPECT_EQ(timeout, nativeConfig.ice_connection_receiving_timeout); 62 EXPECT_EQ(timeout, nativeConfig.ice_connection_receiving_timeout);
62 EXPECT_EQ(interval, nativeConfig.ice_backup_candidate_pair_ping_interval); 63 EXPECT_EQ(interval, nativeConfig.ice_backup_candidate_pair_ping_interval);
64 EXPECT_EQ(webrtc::PeerConnectionInterface::GATHER_CONTINUALLY,
65 nativeConfig.continual_gathering_policy);
63 } 66 }
64 67
65 @end 68 @end
66 69
67 TEST(RTCConfigurationTest, NativeConfigurationConversionTest) { 70 TEST(RTCConfigurationTest, NativeConfigurationConversionTest) {
68 @autoreleasepool { 71 @autoreleasepool {
69 RTCConfigurationTest *test = [[RTCConfigurationTest alloc] init]; 72 RTCConfigurationTest *test = [[RTCConfigurationTest alloc] init];
70 [test testConversionToNativeConfiguration]; 73 [test testConversionToNativeConfiguration];
71 } 74 }
72 } 75 }
73 76
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698