Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1971513002:
IWYU: errno.h in base/logging.h (Closed)
|
Created:
4 years, 7 months ago by Mostyn Bramley-Moore Modified:
4 years, 7 months ago Reviewers:
Henrik Grunell WebRTC CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionIWYU: errno.h in base/logging.h
Without this, some toolchains may fail to build base/checks.cc
because errno is undefined.
NOTRY=true
Committed: https://crrev.com/e38e4f6e48d13dc6958a5308573256d768f78315
Cr-Commit-Position: refs/heads/master@{#12696}
Patch Set 1 #
Messages
Total messages: 20 (9 generated)
mostynb@opera.com changed reviewers: + henrikg@webrtc.org
@Henrik: here is a webrtc patch which corresponds to https://codereview.chromium.org/1967643002/
lgtm
The CQ bit was checked by mostynb@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971513002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...)
The CQ bit was checked by mostynb@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971513002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...)
On 2016/05/11 13:30:42, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED, > http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...) This failure looks unrelated. Is this builder broken for others too?
On 2016/05/11 13:51:17, Mostyn Bramley-Moore wrote: > On 2016/05/11 13:30:42, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED, > > > http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...) > > This failure looks unrelated. Is this builder broken for others too? Yes, this is because of https://bugs.chromium.org/p/chromium/issues/detail?id=610145 I'll land it.
Description was changed from ========== IWYU: errno.h in base/logging.h Without this, some toolchains may fail to build base/checks.cc because errno is undefined. ========== to ========== IWYU: errno.h in base/logging.h Without this, some toolchains may fail to build base/checks.cc because errno is undefined. NOTRY=true ==========
The CQ bit was checked by henrikg@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1971513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1971513002/1
Message was sent while issue was closed.
Description was changed from ========== IWYU: errno.h in base/logging.h Without this, some toolchains may fail to build base/checks.cc because errno is undefined. NOTRY=true ========== to ========== IWYU: errno.h in base/logging.h Without this, some toolchains may fail to build base/checks.cc because errno is undefined. NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== IWYU: errno.h in base/logging.h Without this, some toolchains may fail to build base/checks.cc because errno is undefined. NOTRY=true ========== to ========== IWYU: errno.h in base/logging.h Without this, some toolchains may fail to build base/checks.cc because errno is undefined. NOTRY=true Committed: https://crrev.com/e38e4f6e48d13dc6958a5308573256d768f78315 Cr-Commit-Position: refs/heads/master@{#12696} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e38e4f6e48d13dc6958a5308573256d768f78315 Cr-Commit-Position: refs/heads/master@{#12696} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
