New UI for AppRTC Android Demo that is easier to use

New UI for AppRTC Android Demo that is easier to use and better follows
Android design guidelines.

BUG=
R=magjed@webrtc.org

Committed: https://crrev.com/57f95dcf9d3a1a6ef9cbf2bb2c0001926930bd08
Cr-Commit-Position: refs/heads/master@{#12758}

[sakal, 2016-05-11 14:52:42]

Description was changed from

==========
New UI for AppRTC Android Demo that is easier to use and better follows
Android design guidelines.

BUG=
==========

to

==========
New UI for AppRTC Android Demo that is easier to use and better follows
Android design guidelines.

BUG=
==========

[sakal, 2016-05-12 10:43:16]

sakal@webrtc.org changed reviewers:
+ magjed@webrtc.org

[sakal, 2016-05-12 10:43:44]

Magjed, can you take a look at this change, please?

[magjed_webrtc, 2016-05-12 12:25:46]

https://codereview.webrtc.org/1970783002/diff/60001/webrtc/examples/androidap...
File webrtc/examples/androidapp/src/org/appspot/apprtc/ConnectActivity.java
(right):

https://codereview.webrtc.org/1970783002/diff/60001/webrtc/examples/androidap...
webrtc/examples/androidapp/src/org/appspot/apprtc/ConnectActivity.java:247:
private void connectToRoom
nit: '(' on should be moved to 'connectToRoom('

https://codereview.webrtc.org/1970783002/diff/60001/webrtc/examples/androidap...
webrtc/examples/androidapp/src/org/appspot/apprtc/ConnectActivity.java:251: //
roomId is random for loopback
nit: dot at end of sentence

https://codereview.webrtc.org/1970783002/diff/60001/webrtc/examples/androidap...
webrtc/examples/androidapp/src/org/appspot/apprtc/ConnectActivity.java:420:
.inflate(R.layout.dialog_add_favorite, null);
Is it really normal to inflate something on every click?

[sakal, 2016-05-16 11:43:00]

https://codereview.webrtc.org/1970783002/diff/60001/webrtc/examples/androidap...
File webrtc/examples/androidapp/src/org/appspot/apprtc/ConnectActivity.java
(right):

https://codereview.webrtc.org/1970783002/diff/60001/webrtc/examples/androidap...
webrtc/examples/androidapp/src/org/appspot/apprtc/ConnectActivity.java:247:
private void connectToRoom
On 2016/05/12 12:25:45, magjed_webrtc wrote:
> nit: '(' on should be moved to 'connectToRoom('

Done.

https://codereview.webrtc.org/1970783002/diff/60001/webrtc/examples/androidap...
webrtc/examples/androidapp/src/org/appspot/apprtc/ConnectActivity.java:251: //
roomId is random for loopback
On 2016/05/12 12:25:45, magjed_webrtc wrote:
> nit: dot at end of sentence

Done.

https://codereview.webrtc.org/1970783002/diff/60001/webrtc/examples/androidap...
webrtc/examples/androidapp/src/org/appspot/apprtc/ConnectActivity.java:420:
.inflate(R.layout.dialog_add_favorite, null);
On 2016/05/12 12:25:45, magjed_webrtc wrote:
> Is it really normal to inflate something on every click?

It is possible to pre-inflate this view for example in onCreate. However, I am
not sure if that makes sense since user probably isn't going to be constantly
adding new favorites. The view is very small (only a TextView and a EditText) so
inflating it shouldn't be a very costly operation.

[magjed_webrtc, 2016-05-16 12:07:37]

lgtm

[sakal, 2016-05-16 12:16:18]

The CQ bit was checked by sakal@webrtc.org

[commit-bot: I haz the power, 2016-05-16 12:16:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1970783002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1970783002/80001

[commit-bot: I haz the power, 2016-05-16 14:16:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-16 14:16:53]

Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[sakal, 2016-05-16 14:20:47]

Patchset #6 (id:100001) has been deleted

[sakal, 2016-05-16 14:21:50]

Description was changed from

==========
New UI for AppRTC Android Demo that is easier to use and better follows
Android design guidelines.

BUG=
==========

to

==========
New UI for AppRTC Android Demo that is easier to use and better follows
Android design guidelines.

BUG=
R=magjed@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/57f95dcf9d3a1a6ef9cbf2bb2...
==========

[sakal, 2016-05-16 14:21:51]

Committed patchset #5 (id:80001) manually as
57f95dcf9d3a1a6ef9cbf2bb2c0001926930bd08 (presubmit successful).

[commit-bot: I haz the power, 2016-05-16 14:21:54]

Description was changed from

==========
New UI for AppRTC Android Demo that is easier to use and better follows
Android design guidelines.

BUG=
R=magjed@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/57f95dcf9d3a1a6ef9cbf2bb2...
==========

to

==========
New UI for AppRTC Android Demo that is easier to use and better follows
Android design guidelines.

BUG=
R=magjed@webrtc.org

Committed: https://crrev.com/57f95dcf9d3a1a6ef9cbf2bb2c0001926930bd08
Cr-Commit-Position: refs/heads/master@{#12758}
==========

[AlexG, 2016-05-20 20:29:08]

glaznev@webrtc.org changed reviewers:
+ glaznev@webrtc.org

[AlexG, 2016-05-20 20:29:08]

https://codereview.webrtc.org/1970783002/diff/80001/webrtc/examples/androidap...
File webrtc/examples/androidapp/src/org/appspot/apprtc/ConnectActivity.java
(right):

https://codereview.webrtc.org/1970783002/diff/80001/webrtc/examples/androidap...
webrtc/examples/androidapp/src/org/appspot/apprtc/ConnectActivity.java:19:
import android.support.design.widget.FloatingActionButton;
Can we please remove this from sample app. It requires linking with design
support library which is inconvenient if you imported project before to any IDE.

I would suggest to stay with custom controls in our sample app.