Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1970513004: Reland of name OpenH264 frame-type conversion function. (Closed)

Created:
4 years, 7 months ago by pbos-webrtc
Modified:
4 years, 7 months ago
Reviewers:
hbos
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of name OpenH264 frame-type conversion function. (patchset #1 id:1 of https://codereview.webrtc.org/1964913002/ ) Reason for revert: Not perf-regression culprit. Original issue's description: > Revert of Rename OpenH264 frame-type conversion function. (patchset #2 id:20001 of https://codereview.webrtc.org/1943193003/ ) > > Reason for revert: > Speculative revert for perf regression (though unlikely). > > Original issue's description: > > Rename OpenH264 frame-type conversion function. > > > > Also removing default case, so if another frame is added to > > EVideoFrameType we have to handle it. > > > > This will now NOTREACHED on videoFrameTypeInvalid, but > > videoFrameTypeInvalid shouldn't happen if encoding succeeds, so it > > should be fine or we should become aware of it. > > > > BUG= > > R=hbos@webrtc.org > > > > Committed: https://crrev.com/39a36705ab734914d500b8a0f214ea630d82ab70 > > Cr-Commit-Position: refs/heads/master@{#12636} > > TBR=hbos@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=chromium:610347 > > Committed: https://crrev.com/1abf937cecea56ee02ac4a08980ffea9e7ed1054 > Cr-Commit-Position: refs/heads/master@{#12677} TBR=hbos@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:610347 Committed: https://crrev.com/b6e8f2f7a713b1c05786337b4fe2a778f2b8f88a Cr-Commit-Position: refs/heads/master@{#12679}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc View 3 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
pbos-webrtc
Created Reland of name OpenH264 frame-type conversion function.
4 years, 7 months ago (2016-05-11 07:58:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1970513004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1970513004/1
4 years, 7 months ago (2016-05-11 07:58:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 07:58:40 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 07:58:52 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b6e8f2f7a713b1c05786337b4fe2a778f2b8f88a
Cr-Commit-Position: refs/heads/master@{#12679}

Powered by Google App Engine
This is Rietveld 408576698