Make sure WebRTC works without libvpx VP9 support.

Make sure WebRTC works without libvpx VP9 support.

Wires up existing libvpx_build_vp9==0 GYP flag into WebRTC and makes VP9
optional. Change is GYP only for now since libvpx's GN files build VP9
unconditionally.

BUG=webrtc:5884
R=kjellander@webrtc.org

Committed: https://crrev.com/1299615838ccb2ae1520ac9724a7f2b7e6c7919c
Cr-Commit-Position: refs/heads/master@{#12741}

[pbos-webrtc, 2016-05-12 19:45:08]

PTAL, this gyp flag is already available in third_party/libvpx/libvpx.gyp and 1
by default.

[pbos-webrtc, 2016-05-12 19:45:17]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-12 19:45:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1970343002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1970343002/1

[commit-bot: I haz the power, 2016-05-12 19:50:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 19:50:11]

Dry run: Try jobs failed on following builders:
  presubmit on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/5499)

[pbos-webrtc, 2016-05-12 19:53:56]

add test to make sure VP9 support isn't announced

[kjellander_webrtc, 2016-05-13 05:26:15]

lgtm with a GYP question though

https://codereview.webrtc.org/1970343002/diff/20001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcvideoengine2.cc (right):

https://codereview.webrtc.org/1970343002/diff/20001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvideoengine2.cc:31: #include
"webrtc/modules/video_coding/codecs/vp9/include/vp9.h"
nit: Sort 9 > 8

https://codereview.webrtc.org/1970343002/diff/20001/webrtc/modules/modules.gyp
File webrtc/modules/modules.gyp (left):

https://codereview.webrtc.org/1970343002/diff/20001/webrtc/modules/modules.gy...
webrtc/modules/modules.gyp:66:
'<(webrtc_root)/modules/video_coding/codecs/vp9/vp9.gyp:webrtc_vp9',
Shouldn't this also go into the condition?

[pbos-webrtc, 2016-05-14 00:00:26]

Description was changed from

==========
Make sure WebRTC works without libvpx VP9 support.

Wires up existing libvpx_build_vp9==0 GYP flag into WebRTC and makes VP9
optional. Change is GYP only for now since libvpx's GN files build VP9
unconditionally.

BUG=webrtc:5884
R=kjellander@webrtc.org, marpan@webrtc.org
==========

to

==========
Make sure WebRTC works without libvpx VP9 support.

Wires up existing libvpx_build_vp9==0 GYP flag into WebRTC and makes VP9
optional. Change is GYP only for now since libvpx's GN files build VP9
unconditionally.

BUG=webrtc:5884
R=kjellander@webrtc.org
TBR=marpan@webrtc.org
==========

[pbos-webrtc, 2016-05-14 00:01:01]

Description was changed from

==========
Make sure WebRTC works without libvpx VP9 support.

Wires up existing libvpx_build_vp9==0 GYP flag into WebRTC and makes VP9
optional. Change is GYP only for now since libvpx's GN files build VP9
unconditionally.

BUG=webrtc:5884
R=kjellander@webrtc.org
TBR=marpan@webrtc.org
==========

to

==========
Make sure WebRTC works without libvpx VP9 support.

Wires up existing libvpx_build_vp9==0 GYP flag into WebRTC and makes VP9
optional. Change is GYP only for now since libvpx's GN files build VP9
unconditionally.

BUG=webrtc:5884
R=kjellander@webrtc.org
==========

[pbos-webrtc, 2016-05-14 00:01:01]

pbos@webrtc.org changed reviewers:
- marpan@webrtc.org

[pbos-webrtc, 2016-05-14 00:03:06]

https://codereview.webrtc.org/1970343002/diff/20001/webrtc/media/engine/webrt...
File webrtc/media/engine/webrtcvideoengine2.cc (right):

https://codereview.webrtc.org/1970343002/diff/20001/webrtc/media/engine/webrt...
webrtc/media/engine/webrtcvideoengine2.cc:31: #include
"webrtc/modules/video_coding/codecs/vp9/include/vp9.h"
On 2016/05/13 05:26:15, kjellander (webrtc) wrote:
> nit: Sort 9 > 8

Done.

https://codereview.webrtc.org/1970343002/diff/20001/webrtc/modules/modules.gyp
File webrtc/modules/modules.gyp (left):

https://codereview.webrtc.org/1970343002/diff/20001/webrtc/modules/modules.gy...
webrtc/modules/modules.gyp:66:
'<(webrtc_root)/modules/video_coding/codecs/vp9/vp9.gyp:webrtc_vp9',
On 2016/05/13 05:26:15, kjellander (webrtc) wrote:
> Shouldn't this also go into the condition?

No this target doesn't use vp9 at all (modules_unittests below does and includes
webrtc_vp9 unconditionally).

[pbos-webrtc, 2016-05-14 00:03:09]

sort headers

[pbos-webrtc, 2016-05-14 00:03:33]

Description was changed from

==========
Make sure WebRTC works without libvpx VP9 support.

Wires up existing libvpx_build_vp9==0 GYP flag into WebRTC and makes VP9
optional. Change is GYP only for now since libvpx's GN files build VP9
unconditionally.

BUG=webrtc:5884
R=kjellander@webrtc.org
==========

to

==========
Make sure WebRTC works without libvpx VP9 support.

Wires up existing libvpx_build_vp9==0 GYP flag into WebRTC and makes VP9
optional. Change is GYP only for now since libvpx's GN files build VP9
unconditionally.

BUG=webrtc:5884
R=kjellander@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/1299615838ccb2ae1520ac972...
==========

[pbos-webrtc, 2016-05-14 00:03:34]

Committed patchset #3 (id:40001) manually as
1299615838ccb2ae1520ac9724a7f2b7e6c7919c (presubmit successful).

[commit-bot: I haz the power, 2016-05-14 00:03:38]

Description was changed from

==========
Make sure WebRTC works without libvpx VP9 support.

Wires up existing libvpx_build_vp9==0 GYP flag into WebRTC and makes VP9
optional. Change is GYP only for now since libvpx's GN files build VP9
unconditionally.

BUG=webrtc:5884
R=kjellander@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/1299615838ccb2ae1520ac972...
==========

to

==========
Make sure WebRTC works without libvpx VP9 support.

Wires up existing libvpx_build_vp9==0 GYP flag into WebRTC and makes VP9
optional. Change is GYP only for now since libvpx's GN files build VP9
unconditionally.

BUG=webrtc:5884
R=kjellander@webrtc.org

Committed: https://crrev.com/1299615838ccb2ae1520ac9724a7f2b7e6c7919c
Cr-Commit-Position: refs/heads/master@{#12741}
==========