webrtc/pc/channel.h - Issue 1970223002: Fix race in BaseChannel destructor when network thread differ from worker thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/pc/channel.h

Issue 1970223002: Fix race in BaseChannel destructor when network thread differ from worker thread (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/pc/channel.h

diff --git a/webrtc/pc/channel.h b/webrtc/pc/channel.h

index df75245f276d039b7af827f3470eda152a0c4e18..2f66f12c137d02185d1a03b221bb43f9b069098c 100644

--- a/webrtc/pc/channel.h

+++ b/webrtc/pc/channel.h

@@ -314,7 +314,8 @@ class BaseChannel

private:

bool InitNetwork_n();

- void DeinitNetwork_n();

+ void DisconnectTransportChannels_n();

+ void DestroyTransportChannels_n();

void SignalSentPacket_n(TransportChannel* channel,

const rtc::SentPacket& sent_packet);

void SignalSentPacket_w(const rtc::SentPacket& sent_packet);

« no previous file with comments | « no previous file | webrtc/pc/channel.cc » ('j') | no next file with comments »