Fix race in BaseChannel destructor when network thread differ from worker thread

Fix BaseChannel destructor when network thread differ from worker thread

BUG=webrtc:5645
R=pthatcher@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/dae07bae82c0c92e062c451a0648c70015593018

[danilchap, 2016-05-12 15:41:17]

danilchap@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[danilchap, 2016-05-12 15:41:18]

transport channel may signal ReadPacket on network thread while BaseChannel is
destructing on worker thread.
This CL address that issue missed in CL that introduced network thread
(https://codereview.webrtc.org/1903393004/)

[pthatcher1, 2016-05-13 18:33:28]

lgtm, with nit

https://codereview.webrtc.org/1970223002/diff/20001/webrtc/pc/channel.cc
File webrtc/pc/channel.cc (right):

https://codereview.webrtc.org/1970223002/diff/20001/webrtc/pc/channel.cc#newc...
webrtc/pc/channel.cc:261: // Packets arrive on network thread, processing
packets calls virtual
on network thread => on the network thread

[danilchap, 2016-05-13 22:34:50]

The CQ bit was checked by danilchap@webrtc.org

[danilchap, 2016-05-13 22:34:50]

The patchset sent to the CQ was uploaded after l-g-t-m from pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1970223002/#ps40001 (title:
" ")

[commit-bot: I haz the power, 2016-05-13 22:34:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1970223002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1970223002/40001

[commit-bot: I haz the power, 2016-05-13 23:08:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 23:08:09]

Try jobs failed on following builders:
  linux_msan on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_msan/builds/10082)

[commit-bot: I haz the power, 2016-05-13 23:44:05]

Description was changed from

==========
Fix BaseChannel destructor when network thread differ from worker thread

BUG=webrtc:5645
==========

to

==========
Fix BaseChannel destructor when network thread differ from worker thread

BUG=webrtc:5645
R=pthatcher@webrtc.org

Committed: https://crrev.com/dae07bae82c0c92e062c451a0648c70015593018
Cr-Commit-Position: refs/heads/master@{#12740}
==========

[danilchap, 2016-05-13 23:44:05]

Description was changed from

==========
Fix BaseChannel destructor when network thread differ from worker thread

BUG=webrtc:5645
R=pthatcher@webrtc.org

Committed: https://crrev.com/dae07bae82c0c92e062c451a0648c70015593018
Cr-Commit-Position: refs/heads/master@{#12740}
==========

to

==========
Fix BaseChannel destructor when network thread differ from worker thread

BUG=webrtc:5645
R=pthatcher@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/dae07bae82c0c92e062c451a0...
==========

[commit-bot: I haz the power, 2016-05-13 23:44:05]

Patchset 4 (id:??) landed as
https://crrev.com/dae07bae82c0c92e062c451a0648c70015593018
Cr-Commit-Position: refs/heads/master@{#12740}

[danilchap, 2016-05-13 23:44:07]

Committed patchset #4 (id:60001) manually as
dae07bae82c0c92e062c451a0648c70015593018 (presubmit successful).