Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1969403002: Add magjed@ and perkj@ as webrtc/examples/ owners (Closed)

Created:
4 years, 7 months ago by magjed_webrtc
Modified:
4 years, 7 months ago
Reviewers:
tommi
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, AlexG
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add magjed@ and perkj@ as webrtc/examples/ owners NOTRY=true Committed: https://crrev.com/b9253060b80c165ea20fb42a5ee0fc747f19a70c Cr-Commit-Position: refs/heads/master@{#12698}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Sort owners #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M webrtc/examples/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
magjed_webrtc
tommi - Please take a look.
4 years, 7 months ago (2016-05-12 09:32:40 UTC) #2
tommi
lgtm with the list sorted. also added notry to the description. https://codereview.webrtc.org/1969403002/diff/1/webrtc/examples/OWNERS File webrtc/examples/OWNERS (right): ...
4 years, 7 months ago (2016-05-12 09:44:49 UTC) #4
magjed_webrtc
https://codereview.webrtc.org/1969403002/diff/1/webrtc/examples/OWNERS File webrtc/examples/OWNERS (right): https://codereview.webrtc.org/1969403002/diff/1/webrtc/examples/OWNERS#newcode3 webrtc/examples/OWNERS:3: magjed@webrtc.org On 2016/05/12 09:44:49, tommi-webrtc wrote: > can you ...
4 years, 7 months ago (2016-05-12 10:44:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1969403002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1969403002/20001
4 years, 7 months ago (2016-05-12 10:44:28 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-12 10:48:26 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 10:48:33 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b9253060b80c165ea20fb42a5ee0fc747f19a70c
Cr-Commit-Position: refs/heads/master@{#12698}

Powered by Google App Engine
This is Rietveld 408576698