Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1968853002: Modernize variable names (Closed)

Created:
4 years, 7 months ago by kwiberg-webrtc
Modified:
4 years, 7 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Modernize variable names As promised in https://codereview.webrtc.org/1946873003/diff/1/webrtc/modules/utility/source/coder.h#newcode54 NOTRY=True Committed: https://crrev.com/8a7071485131e361f648c2997e60cd093df4887c Cr-Commit-Position: refs/heads/master@{#12683}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -67 lines) Patch
M webrtc/modules/utility/source/coder.h View 1 chunk +21 lines, -21 lines 0 comments Download
M webrtc/modules/utility/source/coder.cc View 1 chunk +46 lines, -46 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
kwiberg-webrtc
4 years, 7 months ago (2016-05-11 01:52:40 UTC) #2
perkj_webrtc
lgtm
4 years, 7 months ago (2016-05-11 09:08:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968853002/1
4 years, 7 months ago (2016-05-11 09:42:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg/builds/3905)
4 years, 7 months ago (2016-05-11 09:51:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968853002/1
4 years, 7 months ago (2016-05-11 11:25:04 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-11 11:26:44 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 11:27:10 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a7071485131e361f648c2997e60cd093df4887c
Cr-Commit-Position: refs/heads/master@{#12683}

Powered by Google App Engine
This is Rietveld 408576698