Audio codec usage statistics

webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.h

Index: webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.h
diff --git a/webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.h b/webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.h
index eb5ad0287844ca7bfb78995a232f9c4ae48119d5..3a2c05e0b39a071d64ae19296264c0e657aa3777 100644
--- a/webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.h
+++ b/webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.h
@@ -55,6 +55,12 @@ class AudioEncoderPcm : public AudioEncoder {
 
   virtual size_t BytesPerSample() const = 0;
 
+  // Returns a pointer to a statically allocated string with the codec
+  // name, e.g. "g711A" or "g711U". The default implementation returns
+  // null, which means no name. Used to set
+  // EncodedInfoLeaf::encoder_name in AudioEncoderPcm::EncodeImpl
+  virtual const char* GetCodecName() const;

[ossu, 2016/05/12 12:50:14]

I think this should have a name that refers to logging as well, since that's
what it's used for (and the name must match something in a chromium XML file,
IIRC).

[aleloi, 2016/05/12 13:25:47]

The names in WebRTC and histograms.xml do not have to match. Only numbers are
sent in the UMA communication between WebRTC and chromium. I define names in the
XML to know what the numbers correspond to.

I am not sure about this and about what to change to. It's not specifically
tailored to logging, the name could in principle be used for something else.

+
  private:
   const int sample_rate_hz_;
   const size_t num_channels_;
@@ -84,6 +90,8 @@ class AudioEncoderPcmA final : public AudioEncoderPcm {
 
   size_t BytesPerSample() const override;
 
+  const char* GetCodecName() const override;
+
  private:
   static const int kSampleRateHz = 8000;
   RTC_DISALLOW_COPY_AND_ASSIGN(AudioEncoderPcmA);
@@ -106,6 +114,8 @@ class AudioEncoderPcmU final : public AudioEncoderPcm {
 
   size_t BytesPerSample() const override;
 
+  const char* GetCodecName() const override;
+
  private:
   static const int kSampleRateHz = 8000;
   RTC_DISALLOW_COPY_AND_ASSIGN(AudioEncoderPcmU);