Audio codec usage statistics

webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.h

Index: webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.h
diff --git a/webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.h b/webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.h
index eb5ad0287844ca7bfb78995a232f9c4ae48119d5..33788e22a78354b687841d4e5abc45c3d26e81a9 100644
--- a/webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.h
+++ b/webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.h
@@ -55,6 +55,11 @@ class AudioEncoderPcm : public AudioEncoder {
 
   virtual size_t BytesPerSample() const = 0;
 
+  // The default implementation returns kOther, which means no name,
+  // other or unknown codec. Used to set EncodedInfoLeaf::encoder_type
+  // in AudioEncoderPcm::EncodeImpl
+  virtual AudioEncoder::CodecType GetCodecType() const;

[kwiberg-webrtc, 2016/05/12 23:30:21]

Again, it's probably much simpler to =0 here and just force all three subclasses
to define the method.

[aleloi, 2016/05/13 09:02:27]

To clarify: you suggest changing this to =0, make pcmA return kPcmA, pcmB return
kPcmB and pcm16b return kOther? 

Why do you think is it much simpler? (It doesn't matter for me, but I'd like to
follow your reasoning).

[kwiberg-webrtc, 2016/05/15 02:06:13]

Exactly.
Because then the value used by each class is specified with that class. It means
you'll have to look in fewer places when reading the code.

Also because overriding an =0 method is a simpler concept than overriding a
method with a default value; instead of "each codec has to say what value it
wants", you get "each codec may optionally say what value it wants, and if it
doesn't, it gets this default value instead".

IOW, I'm lazy, and I don't want to have to think more than necessary when
reading code. (This is a surprisingly useful design principle.)

[aleloi, 2016/05/16 08:02:23]

Done.

+
  private:
   const int sample_rate_hz_;
   const size_t num_channels_;
@@ -84,6 +89,8 @@ class AudioEncoderPcmA final : public AudioEncoderPcm {
 
   size_t BytesPerSample() const override;
 
+  AudioEncoder::CodecType GetCodecType() const override;
+
  private:
   static const int kSampleRateHz = 8000;
   RTC_DISALLOW_COPY_AND_ASSIGN(AudioEncoderPcmA);
@@ -106,6 +113,8 @@ class AudioEncoderPcmU final : public AudioEncoderPcm {
 
   size_t BytesPerSample() const override;
 
+  AudioEncoder::CodecType GetCodecType() const override;
+
  private:
   static const int kSampleRateHz = 8000;
   RTC_DISALLOW_COPY_AND_ASSIGN(AudioEncoderPcmU);