Audio codec usage statistics

webrtc/modules/audio_coding/acm2/audio_coding_module_impl.h

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #ifndef WEBRTC_MODULES_AUDIO_CODING_ACM2_AUDIO_CODING_MODULE_IMPL_H_
 #define WEBRTC_MODULES_AUDIO_CODING_ACM2_AUDIO_CODING_MODULE_IMPL_H_
 
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "webrtc/base/buffer.h"
 #include "webrtc/base/criticalsection.h"
 #include "webrtc/base/thread_annotations.h"
 #include "webrtc/common_types.h"
 #include "webrtc/engine_configurations.h"
 #include "webrtc/modules/audio_coding/acm2/acm_receiver.h"
 #include "webrtc/modules/audio_coding/acm2/acm_resampler.h"
 #include "webrtc/modules/audio_coding/acm2/codec_manager.h"
+#include "webrtc/modules/audio_coding/codecs/audio_encoder.h"
 
 namespace webrtc {
 
 class AudioCodingImpl;
 
 namespace acm2 {
 
 struct EncoderFactory;
 
 class AudioCodingModuleImpl final : public AudioCodingModule {
@@ skipping 252 matching lines @@
   bool first_10ms_data_ GUARDED_BY(acm_crit_sect_);
 
   bool first_frame_ GUARDED_BY(acm_crit_sect_);
   uint32_t last_timestamp_ GUARDED_BY(acm_crit_sect_);
   uint32_t last_rtp_timestamp_ GUARDED_BY(acm_crit_sect_);
 
   rtc::CriticalSection callback_crit_sect_;
   AudioPacketizationCallback* packetization_callback_
       GUARDED_BY(callback_crit_sect_);
   ACMVADCallback* vad_callback_ GUARDED_BY(callback_crit_sect_);
+
+  size_t codec_histogram_bins_log_[static_cast<size_t>(
+      AudioEncoder::CodecType::kMaxLoggedAudioCodecNames)];
+  size_t number_of_consecutive_empty_packets_;

[kwiberg-webrtc, 2016/05/12 23:30:21]

Why size_t? I would have thought that the counters should be the same size on
32- and 64-bit machines. (I believe I already asked this. Sorry if I missed your
reply.)

[aleloi, 2016/05/13 09:02:27]

No, it was I who probably missed your question. After reading SO, I have become
convinced that changing to 'unsigned int' is more consistent.

[kwiberg-webrtc, 2016/05/15 02:06:13]

You still haven't changed this.

Also, use int, not unsigned int. See
https://google.github.io/styleguide/cppguide.html#Integer_Types

[aleloi, 2016/05/16 08:02:23]

Done.

 };
 
 }  // namespace acm2
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_AUDIO_CODING_ACM2_AUDIO_CODING_MODULE_IMPL_H_