NetEq: Implement Expand::Muted

NetEq: Implement Expand::Muted

Adding a new method to the Expand class, which will answer the question
whether an ongoing expansion has been faded down to zero
amplitude (i.e., been muted). Also adding a test.

This new functionality will be used in CLs to follow.

BUG=webrtc:5608
NOTRY=True

Committed: https://crrev.com/f3995f71cec25402ee516707543dc7d76f2f3edb
Cr-Commit-Position: refs/heads/master@{#12672}

[hlundin-webrtc, 2016-05-10 11:29:08]

henrik.lundin@webrtc.org changed reviewers:
+ minyue@webrtc.org

[hlundin-webrtc, 2016-05-10 11:29:08]

Minyue,

Please, take a look at this CL.

Thanks!

[minyue-webrtc, 2016-05-10 11:43:12]

lgtm

one nit

https://codereview.webrtc.org/1967473004/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/expand_unittest.cc (right):

https://codereview.webrtc.org/1967473004/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/expand_unittest.cc:189:
EXPECT_FALSE(expand_.Muted());  // Should start unmuted.
not needed, since checked in 175 also.

[hlundin-webrtc, 2016-05-10 11:52:39]

Thanks! The new patch set will be committed.

https://codereview.webrtc.org/1967473004/diff/1/webrtc/modules/audio_coding/n...
File webrtc/modules/audio_coding/neteq/expand_unittest.cc (right):

https://codereview.webrtc.org/1967473004/diff/1/webrtc/modules/audio_coding/n...
webrtc/modules/audio_coding/neteq/expand_unittest.cc:189:
EXPECT_FALSE(expand_.Muted());  // Should start unmuted.
On 2016/05/10 11:43:12, minyue-webrtc wrote:
> not needed, since checked in 175 also.

Done.

[hlundin-webrtc, 2016-05-10 11:52:43]

The CQ bit was checked by henrik.lundin@webrtc.org

[hlundin-webrtc, 2016-05-10 11:52:43]

The patchset sent to the CQ was uploaded after l-g-t-m from minyue@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1967473004/#ps20001 (title:
"Fixing the review nit")

[commit-bot: I haz the power, 2016-05-10 11:52:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1967473004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1967473004/20001

[hlundin-webrtc, 2016-05-10 11:57:46]

Description was changed from

==========
NetEq: Implement Expand::Muted

Adding a new method to the Expand class, which will answer the question
whether an ongoing expansion has been faded down to zero
amplitude (i.e., been muted). Also adding a test.

This new functionality will be used in CLs to follow.

BUG=5608
==========

to

==========
NetEq: Implement Expand::Muted

Adding a new method to the Expand class, which will answer the question
whether an ongoing expansion has been faded down to zero
amplitude (i.e., been muted). Also adding a test.

This new functionality will be used in CLs to follow.

BUG=webrtc:5608
==========

[commit-bot: I haz the power, 2016-05-10 12:09:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-10 12:09:59]

Try jobs failed on following builders:
  android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...)

[hlundin-webrtc, 2016-05-10 12:53:07]

Description was changed from

==========
NetEq: Implement Expand::Muted

Adding a new method to the Expand class, which will answer the question
whether an ongoing expansion has been faded down to zero
amplitude (i.e., been muted). Also adding a test.

This new functionality will be used in CLs to follow.

BUG=webrtc:5608
==========

to

==========
NetEq: Implement Expand::Muted

Adding a new method to the Expand class, which will answer the question
whether an ongoing expansion has been faded down to zero
amplitude (i.e., been muted). Also adding a test.

This new functionality will be used in CLs to follow.

BUG=webrtc:5608
NOTRY=True
==========

[hlundin-webrtc, 2016-05-10 12:53:16]

The CQ bit was checked by henrik.lundin@webrtc.org

[commit-bot: I haz the power, 2016-05-10 12:53:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1967473004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1967473004/20001

[commit-bot: I haz the power, 2016-05-10 12:54:38]

Description was changed from

==========
NetEq: Implement Expand::Muted

Adding a new method to the Expand class, which will answer the question
whether an ongoing expansion has been faded down to zero
amplitude (i.e., been muted). Also adding a test.

This new functionality will be used in CLs to follow.

BUG=webrtc:5608
NOTRY=True
==========

to

==========
NetEq: Implement Expand::Muted

Adding a new method to the Expand class, which will answer the question
whether an ongoing expansion has been faded down to zero
amplitude (i.e., been muted). Also adding a test.

This new functionality will be used in CLs to follow.

BUG=webrtc:5608
NOTRY=True
==========

[commit-bot: I haz the power, 2016-05-10 12:54:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-10 12:54:52]

Description was changed from

==========
NetEq: Implement Expand::Muted

Adding a new method to the Expand class, which will answer the question
whether an ongoing expansion has been faded down to zero
amplitude (i.e., been muted). Also adding a test.

This new functionality will be used in CLs to follow.

BUG=webrtc:5608
NOTRY=True
==========

to

==========
NetEq: Implement Expand::Muted

Adding a new method to the Expand class, which will answer the question
whether an ongoing expansion has been faded down to zero
amplitude (i.e., been muted). Also adding a test.

This new functionality will be used in CLs to follow.

BUG=webrtc:5608
NOTRY=True

Committed: https://crrev.com/f3995f71cec25402ee516707543dc7d76f2f3edb
Cr-Commit-Position: refs/heads/master@{#12672}
==========

[commit-bot: I haz the power, 2016-05-10 12:54:53]

Patchset 2 (id:??) landed as
https://crrev.com/f3995f71cec25402ee516707543dc7d76f2f3edb
Cr-Commit-Position: refs/heads/master@{#12672}