Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1143)

Unified Diff: webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc

Issue 1966213002: Unify hardware and software QP thresholds. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: compromise at 95 Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc
diff --git a/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc b/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc
index b236f4e9557393d1ca2c8d20c1faef9992b225dc..e4101e79d499cc109fa9ed0c4aa56aae32bbfa3e 100644
--- a/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc
+++ b/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc
@@ -598,15 +598,9 @@ int VP8EncoderImpl::InitEncode(const VideoCodec* inst,
}
rps_.Init();
- // QP thresholds are chosen to be high enough to be hit in practice when
- // quality is good, but also low enough to not cause a flip-flop behavior
- // (e.g. going up in resolution shouldn't give so bad quality that we should
- // go back down).
- const int kLowQpThreshold = 29;
- const int kBadQpThreshold = 100;
- quality_scaler_.Init(kLowQpThreshold, kBadQpThreshold,
- codec_.startBitrate, codec_.width, codec_.height,
- codec_.maxFramerate);
+ quality_scaler_.Init(QualityScaler::kLowVp8QpThreshold,
+ QualityScaler::kBadVp8QpThreshold, codec_.startBitrate,
+ codec_.width, codec_.height, codec_.maxFramerate);
// Only apply scaling to improve for single-layer streams. The scaling metrics
// use frame drops as a signal and is only applicable when we drop frames.
« no previous file with comments | « webrtc/api/java/jni/androidmediaencoder_jni.cc ('k') | webrtc/modules/video_coding/utility/quality_scaler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698