Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: webrtc/modules/video_coding/utility/quality_scaler.h

Issue 1966213002: Unify hardware and software QP thresholds. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/utility/quality_scaler.h
diff --git a/webrtc/modules/video_coding/utility/quality_scaler.h b/webrtc/modules/video_coding/utility/quality_scaler.h
index b6d4867be223ef34ac0809b178645089dcc75fae..fe70393c21cdf32d8c11abc062f88acf3a372815 100644
--- a/webrtc/modules/video_coding/utility/quality_scaler.h
+++ b/webrtc/modules/video_coding/utility/quality_scaler.h
@@ -37,6 +37,15 @@ class QualityScaler {
const VideoFrame& GetScaledFrame(const VideoFrame& frame);
int downscale_shift() const { return downscale_shift_; }
+ // QP is obtained from VP8-bitstream for HW, so the QP corresponds to the
+ // bitstream range of [0, 127] and not the user-level range of [0,63].
+ static const int kLowVp8QpThreshold;
+ static const int kBadVp8QpThreshold;
+
+ // H264 QP is in the range [0, 51].
+ static const int kLowH264QpThreshold;
+ static const int kBadH264QpThreshold;
+
private:
void AdjustScale(bool up);
void UpdateTargetResolution(int frame_width, int frame_height);

Powered by Google App Engine
This is Rietveld 408576698