Unify hardware and software QP thresholds.

Unify hardware and software QP thresholds.

Uses current libvpx (slightly older) thresholds to maintain a larger
window of stable QP, but maintains the newer H264 thresholds.

BUG=
R=glaznev@webrtc.org, mflodman@webrtc.org

Committed: https://crrev.com/1f53452ca6abd6c32e95715ae830619a1eaa3ab0
Cr-Commit-Position: refs/heads/master@{#12734}

[pbos-webrtc, 2016-05-11 12:32:05]

PTAL

[AlexG, 2016-05-11 17:13:48]

https://codereview.webrtc.org/1966213002/diff/1/webrtc/modules/video_coding/u...
File webrtc/modules/video_coding/utility/quality_scaler.cc (right):

https://codereview.webrtc.org/1966213002/diff/1/webrtc/modules/video_coding/u...
webrtc/modules/video_coding/utility/quality_scaler.cc:38: const int
QualityScaler::kBadVp8QpThreshold = 100;
I want to keep "bad" threshold at 90 at least for HW codec. 720p encoding may
looks too blocky at QP = 90 and never downscale

[pbos-webrtc, 2016-05-11 17:19:27]

https://codereview.webrtc.org/1966213002/diff/1/webrtc/modules/video_coding/u...
File webrtc/modules/video_coding/utility/quality_scaler.cc (right):

https://codereview.webrtc.org/1966213002/diff/1/webrtc/modules/video_coding/u...
webrtc/modules/video_coding/utility/quality_scaler.cc:38: const int
QualityScaler::kBadVp8QpThreshold = 100;
On 2016/05/11 17:13:48, AlexG wrote:
> I want to keep "bad" threshold at 90 at least for HW codec. 720p encoding may
> looks too blocky at QP = 90 and never downscale

Are you certain that this doesn't flip-flop for either pretty-still video or
when moving around a bit?

[pbos-webrtc, 2016-05-11 17:30:21]

bump vp8 bad QP to 90

[pbos-webrtc, 2016-05-11 17:38:34]

PTAL if you think this is a better threshold

[AlexG, 2016-05-11 17:43:47]

lgtm

[pbos-webrtc, 2016-05-11 17:54:16]

compromise at 95

[mflodman, 2016-05-13 15:33:18]

lgtm

[mflodman, 2016-05-13 15:34:10]

The CQ bit was checked by mflodman@webrtc.org

[mflodman, 2016-05-13 15:34:11]

The patchset sent to the CQ was uploaded after l-g-t-m from glaznev@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1966213002/#ps40001 (title:
"compromise at 95")

[commit-bot: I haz the power, 2016-05-13 15:34:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1966213002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1966213002/40001

[commit-bot: I haz the power, 2016-05-13 18:05:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-13 18:05:45]

Description was changed from

==========
Unify hardware and software QP thresholds.

Uses current libvpx (slightly older) thresholds to maintain a larger
window of stable QP, but maintains the newer H264 thresholds.

BUG=
R=glaznev@webrtc.org, mflodman@webrtc.org
==========

to

==========
Unify hardware and software QP thresholds.

Uses current libvpx (slightly older) thresholds to maintain a larger
window of stable QP, but maintains the newer H264 thresholds.

BUG=
R=glaznev@webrtc.org, mflodman@webrtc.org

Committed: https://crrev.com/1f53452ca6abd6c32e95715ae830619a1eaa3ab0
Cr-Commit-Position: refs/heads/master@{#12734}
==========

[commit-bot: I haz the power, 2016-05-13 18:05:46]

Patchset 3 (id:??) landed as
https://crrev.com/1f53452ca6abd6c32e95715ae830619a1eaa3ab0
Cr-Commit-Position: refs/heads/master@{#12734}