Reland of Delete webrtc::VideoFrame methods buffer and stride.

webrtc/common_video/i420_video_frame_unittest.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 33 matching lines @@
   frame.set_ntp_time_ms(456);
   EXPECT_EQ(456, frame.ntp_time_ms());
   frame.set_render_time_ms(789);
   EXPECT_EQ(789, frame.render_time_ms());
 }
 
 TEST(TestVideoFrame, SizeAllocation) {
   VideoFrame frame;
   frame. CreateEmptyFrame(10, 10, 12, 14, 220);
   int height = frame.height();
-  int stride_y = frame.stride(kYPlane);
-  int stride_u = frame.stride(kUPlane);
-  int stride_v = frame.stride(kVPlane);
+  int stride_y = frame.video_frame_buffer()->StrideY();
+  int stride_u = frame.video_frame_buffer()->StrideU();
+  int stride_v = frame.video_frame_buffer()->StrideV();
   // Verify that allocated size was computed correctly.
   EXPECT_EQ(ExpectedSize(stride_y, height, kYPlane),
             frame.allocated_size(kYPlane));
   EXPECT_EQ(ExpectedSize(stride_u, height, kUPlane),
             frame.allocated_size(kUPlane));
   EXPECT_EQ(ExpectedSize(stride_v, height, kVPlane),
             frame.allocated_size(kVPlane));
 }
 
 TEST(TestVideoFrame, CopyFrame) {
@@ skipping 27 matching lines @@
                         width + 5, height + 5, stride_y + 5,
                         stride_u, stride_v, kRotation);
   // Frame of smaller dimensions.
   small_frame.CopyFrame(big_frame);
   EXPECT_TRUE(test::FramesEqual(small_frame, big_frame));
   EXPECT_EQ(kRotation, small_frame.rotation());
 
   // Frame of larger dimensions.
   small_frame.CreateEmptyFrame(width, height,
                                stride_y, stride_u, stride_v);
-  memset(small_frame.buffer(kYPlane), 1, small_frame.allocated_size(kYPlane));
-  memset(small_frame.buffer(kUPlane), 2, small_frame.allocated_size(kUPlane));
-  memset(small_frame.buffer(kVPlane), 3, small_frame.allocated_size(kVPlane));
+  memset(small_frame.video_frame_buffer()->MutableDataY(), 1,
+         small_frame.allocated_size(kYPlane));
+  memset(small_frame.video_frame_buffer()->MutableDataU(), 2,
+         small_frame.allocated_size(kUPlane));
+  memset(small_frame.video_frame_buffer()->MutableDataV(), 3,
+         small_frame.allocated_size(kVPlane));
   big_frame.CopyFrame(small_frame);
   EXPECT_TRUE(test::FramesEqual(small_frame, big_frame));
 }
 
 TEST(TestVideoFrame, ShallowCopy) {
   uint32_t timestamp = 1;
   int64_t ntp_time_ms = 2;
   int64_t render_time_ms = 3;
   int stride_y = 15;
   int stride_u = 10;
@@ skipping 17 matching lines @@
   frame1.set_timestamp(timestamp);
   frame1.set_ntp_time_ms(ntp_time_ms);
   frame1.set_render_time_ms(render_time_ms);
   VideoFrame frame2;
   frame2.ShallowCopy(frame1);
 
   // To be able to access the buffers, we need const pointers to the frames.
   const VideoFrame* const_frame1_ptr = &frame1;
   const VideoFrame* const_frame2_ptr = &frame2;
 
-  EXPECT_TRUE(const_frame1_ptr->buffer(kYPlane) ==
-              const_frame2_ptr->buffer(kYPlane));
-  EXPECT_TRUE(const_frame1_ptr->buffer(kUPlane) ==
-              const_frame2_ptr->buffer(kUPlane));
-  EXPECT_TRUE(const_frame1_ptr->buffer(kVPlane) ==
-              const_frame2_ptr->buffer(kVPlane));
+  EXPECT_TRUE(const_frame1_ptr->video_frame_buffer()->DataY() ==
+              const_frame2_ptr->video_frame_buffer()->DataY());
+  EXPECT_TRUE(const_frame1_ptr->video_frame_buffer()->DataU() ==
+              const_frame2_ptr->video_frame_buffer()->DataU());
+  EXPECT_TRUE(const_frame1_ptr->video_frame_buffer()->DataV() ==
+              const_frame2_ptr->video_frame_buffer()->DataV());
 
   EXPECT_EQ(frame2.timestamp(), frame1.timestamp());
   EXPECT_EQ(frame2.ntp_time_ms(), frame1.ntp_time_ms());
   EXPECT_EQ(frame2.render_time_ms(), frame1.render_time_ms());
   EXPECT_EQ(frame2.rotation(), frame1.rotation());
 
   frame2.set_timestamp(timestamp + 1);
   frame2.set_ntp_time_ms(ntp_time_ms + 1);
   frame2.set_render_time_ms(render_time_ms + 1);
   frame2.set_rotation(kVideoRotation_90);
@@ skipping 17 matching lines @@
   uint8_t buffer_y[kSizeY];
   uint8_t buffer_u[kSizeUv];
   uint8_t buffer_v[kSizeUv];
   memset(buffer_y, 16, kSizeY);
   memset(buffer_u, 8, kSizeUv);
   memset(buffer_v, 4, kSizeUv);
   frame2.CreateFrame(buffer_y, buffer_u, buffer_v,
                      width, height, stride_y, stride_uv, stride_uv,
                      kVideoRotation_0);
   // Expect exactly the same pixel data.
-  EXPECT_TRUE(
-      test::EqualPlane(buffer_y, frame2.buffer(kYPlane), stride_y, 15, 15));
-  EXPECT_TRUE(
-      test::EqualPlane(buffer_u, frame2.buffer(kUPlane), stride_uv, 8, 8));
-  EXPECT_TRUE(
-      test::EqualPlane(buffer_v, frame2.buffer(kVPlane), stride_uv, 8, 8));
+  EXPECT_TRUE(test::EqualPlane(buffer_y, frame2.video_frame_buffer()->DataY(),
+                               stride_y, 15, 15));
+  EXPECT_TRUE(test::EqualPlane(buffer_u, frame2.video_frame_buffer()->DataU(),
+                               stride_uv, 8, 8));
+  EXPECT_TRUE(test::EqualPlane(buffer_v, frame2.video_frame_buffer()->DataV(),
+                               stride_uv, 8, 8));
 
   // Compare size.
   EXPECT_LE(kSizeY, frame2.allocated_size(kYPlane));
   EXPECT_LE(kSizeUv, frame2.allocated_size(kUPlane));
   EXPECT_LE(kSizeUv, frame2.allocated_size(kVPlane));
 }
 
 TEST(TestVideoFrame, ReuseAllocation) {
   VideoFrame frame;
   frame.CreateEmptyFrame(640, 320, 640, 320, 320);
-  const uint8_t* y = frame.buffer(kYPlane);
-  const uint8_t* u = frame.buffer(kUPlane);
-  const uint8_t* v = frame.buffer(kVPlane);
+  const uint8_t* y = frame.video_frame_buffer()->DataY();
+  const uint8_t* u = frame.video_frame_buffer()->DataU();
+  const uint8_t* v = frame.video_frame_buffer()->DataV();
   frame.CreateEmptyFrame(640, 320, 640, 320, 320);
-  EXPECT_EQ(y, frame.buffer(kYPlane));
-  EXPECT_EQ(u, frame.buffer(kUPlane));
-  EXPECT_EQ(v, frame.buffer(kVPlane));
+  EXPECT_EQ(y, frame.video_frame_buffer()->DataY());
+  EXPECT_EQ(u, frame.video_frame_buffer()->DataU());
+  EXPECT_EQ(v, frame.video_frame_buffer()->DataV());
 }
 
 TEST(TestVideoFrame, FailToReuseAllocation) {
   VideoFrame frame1;
   frame1.CreateEmptyFrame(640, 320, 640, 320, 320);
-  const uint8_t* y = frame1.buffer(kYPlane);
-  const uint8_t* u = frame1.buffer(kUPlane);
-  const uint8_t* v = frame1.buffer(kVPlane);
+  const uint8_t* y = frame1.video_frame_buffer()->DataY();
+  const uint8_t* u = frame1.video_frame_buffer()->DataU();
+  const uint8_t* v = frame1.video_frame_buffer()->DataV();
   // Make a shallow copy of |frame1|.
   VideoFrame frame2(frame1.video_frame_buffer(), 0, 0, kVideoRotation_0);
   frame1.CreateEmptyFrame(640, 320, 640, 320, 320);
-  EXPECT_NE(y, frame1.buffer(kYPlane));
-  EXPECT_NE(u, frame1.buffer(kUPlane));
-  EXPECT_NE(v, frame1.buffer(kVPlane));
+  EXPECT_NE(y, frame1.video_frame_buffer()->DataY());
+  EXPECT_NE(u, frame1.video_frame_buffer()->DataU());
+  EXPECT_NE(v, frame1.video_frame_buffer()->DataV());
 }
 
 TEST(TestVideoFrame, TextureInitialValues) {
   test::FakeNativeHandle* handle = new test::FakeNativeHandle();
   VideoFrame frame = test::FakeNativeHandle::CreateFrame(
       handle, 640, 480, 100, 10, webrtc::kVideoRotation_0);
   EXPECT_EQ(640, frame.width());
   EXPECT_EQ(480, frame.height());
   EXPECT_EQ(100u, frame.timestamp());
   EXPECT_EQ(10, frame.render_time_ms());
@@ skipping 10 matching lines @@
   rtc::scoped_refptr<I420Buffer> buf1(
       new rtc::RefCountedObject<I420Buffer>(20, 10));
   memset(buf1->MutableDataY(), 1, 200);
   memset(buf1->MutableDataU(), 2, 50);
   memset(buf1->MutableDataV(), 3, 50);
   rtc::scoped_refptr<I420Buffer> buf2 = I420Buffer::Copy(buf1);
   EXPECT_TRUE(test::FrameBufsEqual(buf1, buf2));
 }
 
 }  // namespace webrtc