Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: webrtc/modules/pacing/bitrate_prober.cc

Issue 1962303002: Added cluster id to PacedSender::Callback::TimeToSendPacket. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/pacing/paced_sender.h » ('j') | webrtc/modules/pacing/paced_sender.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/pacing/bitrate_prober.cc
diff --git a/webrtc/modules/pacing/bitrate_prober.cc b/webrtc/modules/pacing/bitrate_prober.cc
index db42666dc6b89f67ad77363074f85fb0332faf2f..c94f367dd2a3088152530d88421a30879372ef55 100644
--- a/webrtc/modules/pacing/bitrate_prober.cc
+++ b/webrtc/modules/pacing/bitrate_prober.cc
@@ -67,7 +67,7 @@ void BitrateProber::OnIncomingPacket(uint32_t bitrate_bps,
const int kPacketsPerProbe = 5;
const float kProbeBitrateMultipliers[kMaxNumProbes] = {3, 6};
std::stringstream bitrate_log;
- bitrate_log << "Start probing for bandwidth, bitrates:";
danilchap 2016/05/10 15:31:39 is log message change related to cluster_id?
philipel 2016/05/11 09:39:16 No, not really. It was formatted a bit strangely s
+ bitrate_log << "Start probing for bandwidth, (bitrate:packets): ";
for (int i = 0; i < kMaxNumProbes; ++i) {
ProbeCluster cluster;
// We need one extra to get 5 deltas for the first probe, therefore (i == 0)
@@ -75,8 +75,8 @@ void BitrateProber::OnIncomingPacket(uint32_t bitrate_bps,
cluster.probe_bitrate_bps = kProbeBitrateMultipliers[i] * bitrate_bps;
cluster.id = cluster_id_++;
- bitrate_log << " " << cluster.probe_bitrate_bps;
- bitrate_log << ", num packets: " << cluster.max_probe_packets;
+ bitrate_log << "(" << cluster.probe_bitrate_bps << ":";
+ bitrate_log << cluster.max_probe_packets << ") ";
clusters_.push(cluster);
}
« no previous file with comments | « no previous file | webrtc/modules/pacing/paced_sender.h » ('j') | webrtc/modules/pacing/paced_sender.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698