Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1962013003:
Removed MaxEncodedBytes from AudioEncoder. (Closed)
|
Created:
4 years, 7 months ago by ossu Modified:
4 years, 7 months ago Reviewers:
kwiberg-webrtc CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRemoved MaxEncodedBytes from AudioEncoder.
This is the last step in changing the signature of AudioEncoder::Encode
to taking an rtc::Buffer as its output parameter, rather than a pointer
to and a size parameter.
The notry parameter has been added specifically to work around android_compile_x86_dbg bot failing.
NOTRY=True
BUG=webrtc:5591
Committed: https://crrev.com/7e3968e46ccdeaeeb21474985effb8b4ff35cbcb
Cr-Commit-Position: refs/heads/master@{#12685}
Patch Set 1 #Patch Set 2 : Rebase to get around problem with android_compile_x86_dbg #
Messages
Total messages: 28 (15 generated)
Description was changed from ========== Removed MaxEncodedBytes from AudioEncoder. This is the last step in changing the signature of AudioEncoder::Encode to taking an rtc::Buffer as its output parameter, rather than a pointer to and a size parameter. BUG=webrtc:5591 ========== to ========== Removed MaxEncodedBytes from AudioEncoder. This is the last step in changing the signature of AudioEncoder::Encode to taking an rtc::Buffer as its output parameter, rather than a pointer to and a size parameter. BUG=webrtc:5591 ==========
ossu@webrtc.org changed reviewers: + kwiberg@webrtc.org
I ran the google3 import tests and tried building chrome with the changes and both passed.
lgtm!
The CQ bit was checked by ossu@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962013003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...)
The CQ bit was checked by ossu@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962013003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...)
The CQ bit was checked by ossu@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962013003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962013003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...)
The CQ bit was checked by ossu@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from kwiberg@webrtc.org Link to the patchset: https://codereview.webrtc.org/1962013003/#ps20001 (title: "Rebase to get around problem with android_compile_x86_dbg")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962013003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962013003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...)
Description was changed from ========== Removed MaxEncodedBytes from AudioEncoder. This is the last step in changing the signature of AudioEncoder::Encode to taking an rtc::Buffer as its output parameter, rather than a pointer to and a size parameter. BUG=webrtc:5591 ========== to ========== Removed MaxEncodedBytes from AudioEncoder. This is the last step in changing the signature of AudioEncoder::Encode to taking an rtc::Buffer as its output parameter, rather than a pointer to and a size parameter. The notry parameter has been added specifically to work around android_compile_x86_dbg bot failing. NOTRY=True BUG=webrtc:5591 ==========
The CQ bit was checked by ossu@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1962013003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1962013003/20001
Message was sent while issue was closed.
Description was changed from ========== Removed MaxEncodedBytes from AudioEncoder. This is the last step in changing the signature of AudioEncoder::Encode to taking an rtc::Buffer as its output parameter, rather than a pointer to and a size parameter. The notry parameter has been added specifically to work around android_compile_x86_dbg bot failing. NOTRY=True BUG=webrtc:5591 ========== to ========== Removed MaxEncodedBytes from AudioEncoder. This is the last step in changing the signature of AudioEncoder::Encode to taking an rtc::Buffer as its output parameter, rather than a pointer to and a size parameter. The notry parameter has been added specifically to work around android_compile_x86_dbg bot failing. NOTRY=True BUG=webrtc:5591 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Removed MaxEncodedBytes from AudioEncoder. This is the last step in changing the signature of AudioEncoder::Encode to taking an rtc::Buffer as its output parameter, rather than a pointer to and a size parameter. The notry parameter has been added specifically to work around android_compile_x86_dbg bot failing. NOTRY=True BUG=webrtc:5591 ========== to ========== Removed MaxEncodedBytes from AudioEncoder. This is the last step in changing the signature of AudioEncoder::Encode to taking an rtc::Buffer as its output parameter, rather than a pointer to and a size parameter. The notry parameter has been added specifically to work around android_compile_x86_dbg bot failing. NOTRY=True BUG=webrtc:5591 Committed: https://crrev.com/7e3968e46ccdeaeeb21474985effb8b4ff35cbcb Cr-Commit-Position: refs/heads/master@{#12685} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/7e3968e46ccdeaeeb21474985effb8b4ff35cbcb Cr-Commit-Position: refs/heads/master@{#12685} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
