Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(678)

Issue 1959923002: Remove Android x86 compilation trybot from CQ. (Closed)

Created:
4 years, 7 months ago by kjellander_webrtc
Modified:
4 years, 7 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove Android x86 compilation trybot from CQ. There's a Goma bug making it fail to compile after rolling in https://codereview.webrtc.org/1963493002/ BUG=chromium:610145 TBR=pbos@webrtc.org NOTRY=True Committed: https://chromium.googlesource.com/external/webrtc/+/d939d48de2d27d3a79b81adcd71f221673bda40f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M infra/config/cq.cfg View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
kjellander_webrtc
4 years, 7 months ago (2016-05-08 18:58:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959923002/1
4 years, 7 months ago (2016-05-08 18:58:48 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d939d48de2d27d3a79b81adcd71f221673bda40f Cr-Commit-Position: refs/heads/master@{#12657}
4 years, 7 months ago (2016-05-08 19:05:05 UTC) #6
kjellander_webrtc
Committed patchset #1 (id:1) manually as d939d48de2d27d3a79b81adcd71f221673bda40f (presubmit successful).
4 years, 7 months ago (2016-05-08 19:05:09 UTC) #8
pbos-webrtc
lgtm, they say it's unrelated in the bug though so maybe this can be reverted ...
4 years, 7 months ago (2016-05-09 16:48:26 UTC) #9
kjellander_webrtc
On 2016/05/09 16:48:26, pbos-webrtc wrote: > lgtm, they say it's unrelated in the bug though ...
4 years, 7 months ago (2016-05-10 20:09:15 UTC) #10
kjellander_webrtc
4 years, 7 months ago (2016-05-18 11:36:20 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1989223002/ by kjellander@webrtc.org.

The reason for reverting is: https://codereview.chromium.org/1985413002/ rolled
in the fix
for libjpeg_turbo's GYP file in Chromium. That was rolled into WebRTC 
in https://codereview.webrtc.org/1985423004/. That means our Android
x86 builds can start working again..

Powered by Google App Engine
This is Rietveld 408576698