Revert of Partial revert of Enable -Winconsistent-missing-override flag

Revert of Partial revert of Enable -Winconsistent-missing-override flag. (patchset #5 id:80001 of https://cod… (patchset #1 id:1 of https://codereview.webrtc.org/1944273002/ )

Reason for revert:
Downstream users updated now.

Original issue's description:
> Partial revert of Enable -Winconsistent-missing-override flag. (patchset #5 id:80001 of https://codereview.webrtc.org/1921653002/ )
>
> Reason for revert:
> This CL breaks the google3 import (but not the import bot).
> This partial revert only reverts the build files. A full revert no longer cleanly applies to ToT, so this was done instead.
>
> Original issue's description:
> > Enable -Winconsistent-missing-override flag.
> >
> > The problem with gmock is worked around by commenting out any other override declarations in classes using gmock.
> >
> > NOPRESUBMIT=True
> > BUG=webrtc:3970
> >
> > Committed: https://crrev.com/ef8b61e11062295365f11b9942f18a08a8b3ec60
> > Cr-Commit-Position: refs/heads/master@{#12563}
>
> TBR=mflodman@webrtc.org,kjellander@webrtc.org,nisse@webrtc.org
> BUG=webrtc:3970
>
> Committed: https://crrev.com/053f91774149a5367ddd531999d4ca69a57dbaa3
> Cr-Commit-Position: refs/heads/master@{#12624}

TBR=kjellander@webrtc.org,mflodman@webrtc.org,ivoc@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:3970
NOTRY=True

Committed: https://crrev.com/4996eaa7a27f1da95ca8027164c4a291bce9ba36
Cr-Commit-Position: refs/heads/master@{#12678}

[nisse-webrtc, 2016-05-10 13:56:46]

Created Revert of Partial revert of Enable -Winconsistent-missing-override flag.
(patchset #5 id:80001 of https://cod…

[commit-bot: I haz the power, 2016-05-10 14:06:23]

The CQ bit was unchecked by commit-bot@chromium.org

[nisse-webrtc, 2016-05-10 14:29:13]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-05-10 14:34:59]

The CQ bit was unchecked by commit-bot@chromium.org

[nisse-webrtc, 2016-05-10 14:35:39]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-05-10 14:41:40]

The CQ bit was unchecked by commit-bot@chromium.org

[kjellander_webrtc, 2016-05-10 20:04:20]

lgtm
the android_compile_x86_dbg  should be excluded (I filed
https://crbug.com/610355 for that), so please add NOTRY=True if it insists of
being run.

[nisse-webrtc, 2016-05-11 06:00:01]

Description was changed from

==========
Revert of Partial revert of Enable -Winconsistent-missing-override flag.
(patchset #5 id:80001 of https://cod… (patchset #1 id:1 of
https://codereview.webrtc.org/1944273002/ )

Reason for revert:
Should hopefully work better now, after a fix to  google3.gypi was landed
(121474238).

Original issue's description:
> Partial revert of Enable -Winconsistent-missing-override flag. (patchset #5
id:80001 of https://codereview.webrtc.org/1921653002/ )
> 
> Reason for revert:
> This CL breaks the google3 import (but not the import bot).
> This partial revert only reverts the build files. A full revert no longer
cleanly applies to ToT, so this was done instead.
> 
> Original issue's description:
> > Enable -Winconsistent-missing-override flag.
> >
> > The problem with gmock is worked around by commenting out any other override
declarations in classes using gmock.
> >
> > NOPRESUBMIT=True
> > BUG=webrtc:3970
> >
> > Committed: https://crrev.com/ef8b61e11062295365f11b9942f18a08a8b3ec60
> > Cr-Commit-Position: refs/heads/master@{#12563}
> 
> TBR=mflodman@webrtc.org,kjellander@webrtc.org,nisse@webrtc.org
> BUG=webrtc:3970
> 
> Committed: https://crrev.com/053f91774149a5367ddd531999d4ca69a57dbaa3
> Cr-Commit-Position: refs/heads/master@{#12624}

TBR=kjellander@webrtc.org,mflodman@webrtc.org,ivoc@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:3970
==========

to

==========
Revert of Partial revert of Enable -Winconsistent-missing-override flag.
(patchset #5 id:80001 of https://cod… (patchset #1 id:1 of
https://codereview.webrtc.org/1944273002/ )

Reason for revert:
Downstream users updated now.

Original issue's description:
> Partial revert of Enable -Winconsistent-missing-override flag. (patchset #5
id:80001 of https://codereview.webrtc.org/1921653002/ )
> 
> Reason for revert:
> This CL breaks the google3 import (but not the import bot).
> This partial revert only reverts the build files. A full revert no longer
cleanly applies to ToT, so this was done instead.
> 
> Original issue's description:
> > Enable -Winconsistent-missing-override flag.
> >
> > The problem with gmock is worked around by commenting out any other override
declarations in classes using gmock.
> >
> > NOPRESUBMIT=True
> > BUG=webrtc:3970
> >
> > Committed: https://crrev.com/ef8b61e11062295365f11b9942f18a08a8b3ec60
> > Cr-Commit-Position: refs/heads/master@{#12563}
> 
> TBR=mflodman@webrtc.org,kjellander@webrtc.org,nisse@webrtc.org
> BUG=webrtc:3970
> 
> Committed: https://crrev.com/053f91774149a5367ddd531999d4ca69a57dbaa3
> Cr-Commit-Position: refs/heads/master@{#12624}

TBR=kjellander@webrtc.org,mflodman@webrtc.org,ivoc@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:3970
==========

[nisse-webrtc, 2016-05-11 06:00:43]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-05-11 06:00:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1959353002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1959353002/1

[commit-bot: I haz the power, 2016-05-11 06:06:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 06:06:03]

Try jobs failed on following builders:
  android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...)

[nisse-webrtc, 2016-05-11 06:22:47]

Description was changed from

==========
Revert of Partial revert of Enable -Winconsistent-missing-override flag.
(patchset #5 id:80001 of https://cod… (patchset #1 id:1 of
https://codereview.webrtc.org/1944273002/ )

Reason for revert:
Downstream users updated now.

Original issue's description:
> Partial revert of Enable -Winconsistent-missing-override flag. (patchset #5
id:80001 of https://codereview.webrtc.org/1921653002/ )
> 
> Reason for revert:
> This CL breaks the google3 import (but not the import bot).
> This partial revert only reverts the build files. A full revert no longer
cleanly applies to ToT, so this was done instead.
> 
> Original issue's description:
> > Enable -Winconsistent-missing-override flag.
> >
> > The problem with gmock is worked around by commenting out any other override
declarations in classes using gmock.
> >
> > NOPRESUBMIT=True
> > BUG=webrtc:3970
> >
> > Committed: https://crrev.com/ef8b61e11062295365f11b9942f18a08a8b3ec60
> > Cr-Commit-Position: refs/heads/master@{#12563}
> 
> TBR=mflodman@webrtc.org,kjellander@webrtc.org,nisse@webrtc.org
> BUG=webrtc:3970
> 
> Committed: https://crrev.com/053f91774149a5367ddd531999d4ca69a57dbaa3
> Cr-Commit-Position: refs/heads/master@{#12624}

TBR=kjellander@webrtc.org,mflodman@webrtc.org,ivoc@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:3970
==========

to

==========
Revert of Partial revert of Enable -Winconsistent-missing-override flag.
(patchset #5 id:80001 of https://cod… (patchset #1 id:1 of
https://codereview.webrtc.org/1944273002/ )

Reason for revert:
Downstream users updated now.

Original issue's description:
> Partial revert of Enable -Winconsistent-missing-override flag. (patchset #5
id:80001 of https://codereview.webrtc.org/1921653002/ )
> 
> Reason for revert:
> This CL breaks the google3 import (but not the import bot).
> This partial revert only reverts the build files. A full revert no longer
cleanly applies to ToT, so this was done instead.
> 
> Original issue's description:
> > Enable -Winconsistent-missing-override flag.
> >
> > The problem with gmock is worked around by commenting out any other override
declarations in classes using gmock.
> >
> > NOPRESUBMIT=True
> > BUG=webrtc:3970
> >
> > Committed: https://crrev.com/ef8b61e11062295365f11b9942f18a08a8b3ec60
> > Cr-Commit-Position: refs/heads/master@{#12563}
> 
> TBR=mflodman@webrtc.org,kjellander@webrtc.org,nisse@webrtc.org
> BUG=webrtc:3970
> 
> Committed: https://crrev.com/053f91774149a5367ddd531999d4ca69a57dbaa3
> Cr-Commit-Position: refs/heads/master@{#12624}

TBR=kjellander@webrtc.org,mflodman@webrtc.org,ivoc@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:3970
NOTRY=True
==========

[nisse-webrtc, 2016-05-11 06:23:03]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2016-05-11 06:23:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1959353002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1959353002/1

[commit-bot: I haz the power, 2016-05-11 06:28:13]

Description was changed from

==========
Revert of Partial revert of Enable -Winconsistent-missing-override flag.
(patchset #5 id:80001 of https://cod… (patchset #1 id:1 of
https://codereview.webrtc.org/1944273002/ )

Reason for revert:
Downstream users updated now.

Original issue's description:
> Partial revert of Enable -Winconsistent-missing-override flag. (patchset #5
id:80001 of https://codereview.webrtc.org/1921653002/ )
> 
> Reason for revert:
> This CL breaks the google3 import (but not the import bot).
> This partial revert only reverts the build files. A full revert no longer
cleanly applies to ToT, so this was done instead.
> 
> Original issue's description:
> > Enable -Winconsistent-missing-override flag.
> >
> > The problem with gmock is worked around by commenting out any other override
declarations in classes using gmock.
> >
> > NOPRESUBMIT=True
> > BUG=webrtc:3970
> >
> > Committed: https://crrev.com/ef8b61e11062295365f11b9942f18a08a8b3ec60
> > Cr-Commit-Position: refs/heads/master@{#12563}
> 
> TBR=mflodman@webrtc.org,kjellander@webrtc.org,nisse@webrtc.org
> BUG=webrtc:3970
> 
> Committed: https://crrev.com/053f91774149a5367ddd531999d4ca69a57dbaa3
> Cr-Commit-Position: refs/heads/master@{#12624}

TBR=kjellander@webrtc.org,mflodman@webrtc.org,ivoc@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:3970
NOTRY=True
==========

to

==========
Revert of Partial revert of Enable -Winconsistent-missing-override flag.
(patchset #5 id:80001 of https://cod… (patchset #1 id:1 of
https://codereview.webrtc.org/1944273002/ )

Reason for revert:
Downstream users updated now.

Original issue's description:
> Partial revert of Enable -Winconsistent-missing-override flag. (patchset #5
id:80001 of https://codereview.webrtc.org/1921653002/ )
> 
> Reason for revert:
> This CL breaks the google3 import (but not the import bot).
> This partial revert only reverts the build files. A full revert no longer
cleanly applies to ToT, so this was done instead.
> 
> Original issue's description:
> > Enable -Winconsistent-missing-override flag.
> >
> > The problem with gmock is worked around by commenting out any other override
declarations in classes using gmock.
> >
> > NOPRESUBMIT=True
> > BUG=webrtc:3970
> >
> > Committed: https://crrev.com/ef8b61e11062295365f11b9942f18a08a8b3ec60
> > Cr-Commit-Position: refs/heads/master@{#12563}
> 
> TBR=mflodman@webrtc.org,kjellander@webrtc.org,nisse@webrtc.org
> BUG=webrtc:3970
> 
> Committed: https://crrev.com/053f91774149a5367ddd531999d4ca69a57dbaa3
> Cr-Commit-Position: refs/heads/master@{#12624}

TBR=kjellander@webrtc.org,mflodman@webrtc.org,ivoc@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:3970
NOTRY=True
==========

[commit-bot: I haz the power, 2016-05-11 06:28:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-11 06:28:30]

Description was changed from

==========
Revert of Partial revert of Enable -Winconsistent-missing-override flag.
(patchset #5 id:80001 of https://cod… (patchset #1 id:1 of
https://codereview.webrtc.org/1944273002/ )

Reason for revert:
Downstream users updated now.

Original issue's description:
> Partial revert of Enable -Winconsistent-missing-override flag. (patchset #5
id:80001 of https://codereview.webrtc.org/1921653002/ )
> 
> Reason for revert:
> This CL breaks the google3 import (but not the import bot).
> This partial revert only reverts the build files. A full revert no longer
cleanly applies to ToT, so this was done instead.
> 
> Original issue's description:
> > Enable -Winconsistent-missing-override flag.
> >
> > The problem with gmock is worked around by commenting out any other override
declarations in classes using gmock.
> >
> > NOPRESUBMIT=True
> > BUG=webrtc:3970
> >
> > Committed: https://crrev.com/ef8b61e11062295365f11b9942f18a08a8b3ec60
> > Cr-Commit-Position: refs/heads/master@{#12563}
> 
> TBR=mflodman@webrtc.org,kjellander@webrtc.org,nisse@webrtc.org
> BUG=webrtc:3970
> 
> Committed: https://crrev.com/053f91774149a5367ddd531999d4ca69a57dbaa3
> Cr-Commit-Position: refs/heads/master@{#12624}

TBR=kjellander@webrtc.org,mflodman@webrtc.org,ivoc@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:3970
NOTRY=True
==========

to

==========
Revert of Partial revert of Enable -Winconsistent-missing-override flag.
(patchset #5 id:80001 of https://cod… (patchset #1 id:1 of
https://codereview.webrtc.org/1944273002/ )

Reason for revert:
Downstream users updated now.

Original issue's description:
> Partial revert of Enable -Winconsistent-missing-override flag. (patchset #5
id:80001 of https://codereview.webrtc.org/1921653002/ )
>
> Reason for revert:
> This CL breaks the google3 import (but not the import bot).
> This partial revert only reverts the build files. A full revert no longer
cleanly applies to ToT, so this was done instead.
>
> Original issue's description:
> > Enable -Winconsistent-missing-override flag.
> >
> > The problem with gmock is worked around by commenting out any other override
declarations in classes using gmock.
> >
> > NOPRESUBMIT=True
> > BUG=webrtc:3970
> >
> > Committed: https://crrev.com/ef8b61e11062295365f11b9942f18a08a8b3ec60
> > Cr-Commit-Position: refs/heads/master@{#12563}
>
> TBR=mflodman@webrtc.org,kjellander@webrtc.org,nisse@webrtc.org
> BUG=webrtc:3970
>
> Committed: https://crrev.com/053f91774149a5367ddd531999d4ca69a57dbaa3
> Cr-Commit-Position: refs/heads/master@{#12624}

TBR=kjellander@webrtc.org,mflodman@webrtc.org,ivoc@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:3970
NOTRY=True

Committed: https://crrev.com/4996eaa7a27f1da95ca8027164c4a291bce9ba36
Cr-Commit-Position: refs/heads/master@{#12678}
==========

[commit-bot: I haz the power, 2016-05-11 06:28:31]

Patchset 1 (id:??) landed as
https://crrev.com/4996eaa7a27f1da95ca8027164c4a291bce9ba36
Cr-Commit-Position: refs/heads/master@{#12678}

[ivoc, 2016-05-12 09:13:07]

On 2016/05/11 06:28:31, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/4996eaa7a27f1da95ca8027164c4a291bce9ba36
> Cr-Commit-Position: refs/heads/master@{#12678}

lgtm