[rtcp] Remb::Parse updated not to use RTCPUtility

[rtcp] Remb::Parse updated not to use RTCPUtility
bitrate field changed to 64bit to match Remb packet format

BUG=webrtc:5260
R=asapersson@webrtc.org

Committed: https://crrev.com/d215ade504482d3e9b399ee137a3bef103e6c733
Cr-Commit-Position: refs/heads/master@{#12702}

[danilchap, 2016-05-11 12:36:24]

Description was changed from

==========
[rtcp] Remb::Parse updated not to use RTCPUtility
bitrate field changed to 64bit to match Remb packet format

BUG=webrtc:5260
==========

to

==========
[rtcp] Remb::Parse updated not to use RTCPUtility
bitrate field changed to 64bit to match Remb packet format

BUG=webrtc:5260
==========

[danilchap, 2016-05-11 12:36:24]

danilchap@webrtc.org changed reviewers:
+ asapersson@webrtc.org

[åsapersson, 2016-05-12 11:06:05]

https://codereview.webrtc.org/1959023002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.cc (right):

https://codereview.webrtc.org/1959023002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.cc:68: LOG(LS_ERROR) << "Invalid
remb bitrate value : " << mantissa
Invalid->Unhandled?

https://codereview.webrtc.org/1959023002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/remb_unittest.cc (right):

https://codereview.webrtc.org/1959023002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/remb_unittest.cc:82:
TEST(RtcpPacketRembTest, ParseFailsOnTooSmallPacketToBeRemb) {
will this test ParseFailsWhenSsrcCountMismatchLength?

[danilchap, 2016-05-12 11:36:35]

https://codereview.webrtc.org/1959023002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.cc (right):

https://codereview.webrtc.org/1959023002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/remb.cc:68: LOG(LS_ERROR) << "Invalid
remb bitrate value : " << mantissa
On 2016/05/12 11:06:05, åsapersson wrote:
> Invalid->Unhandled?

mantissa is 64bit, so shift overflow would mean result > max(uint64_t)

Can bitrate > max(uint64_t) be valid?

https://codereview.webrtc.org/1959023002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtcp_packet/remb_unittest.cc (right):

https://codereview.webrtc.org/1959023002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtcp_packet/remb_unittest.cc:82:
TEST(RtcpPacketRembTest, ParseFailsOnTooSmallPacketToBeRemb) {
On 2016/05/12 11:06:05, åsapersson wrote:
> will this test ParseFailsWhenSsrcCountMismatchLength?

Yes, it fails for the wrong reason.
It should fail before trying to read ssrc count instead.

[åsapersson, 2016-05-12 11:49:11]

lgtm

[danilchap, 2016-05-12 11:50:23]

The CQ bit was checked by danilchap@webrtc.org

[commit-bot: I haz the power, 2016-05-12 11:50:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1959023002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1959023002/20001

[commit-bot: I haz the power, 2016-05-12 12:04:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 12:04:45]

Try jobs failed on following builders:
  android_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_dbg/builds/13252)

[danilchap, 2016-05-12 13:25:55]

Description was changed from

==========
[rtcp] Remb::Parse updated not to use RTCPUtility
bitrate field changed to 64bit to match Remb packet format

BUG=webrtc:5260
==========

to

==========
[rtcp] Remb::Parse updated not to use RTCPUtility
bitrate field changed to 64bit to match Remb packet format

BUG=webrtc:5260
R=asapersson@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/d215ade504482d3e9b399ee13...
==========

[danilchap, 2016-05-12 13:25:56]

Committed patchset #2 (id:20001) manually as
d215ade504482d3e9b399ee137a3bef103e6c733 (presubmit successful).

[commit-bot: I haz the power, 2016-05-12 13:25:57]

Description was changed from

==========
[rtcp] Remb::Parse updated not to use RTCPUtility
bitrate field changed to 64bit to match Remb packet format

BUG=webrtc:5260
R=asapersson@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/d215ade504482d3e9b399ee13...
==========

to

==========
[rtcp] Remb::Parse updated not to use RTCPUtility
bitrate field changed to 64bit to match Remb packet format

BUG=webrtc:5260
R=asapersson@webrtc.org

Committed: https://crrev.com/d215ade504482d3e9b399ee137a3bef103e6c733
Cr-Commit-Position: refs/heads/master@{#12702}
==========