Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1959013003: TMMBRHelp moved from member object/base class to stack object, (Closed)

Created:
4 years, 7 months ago by danilchap
Modified:
4 years, 7 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

TMMBRHelp moved from member object/base class to stack object, indicating the usage of this helper is local. With local usage critical section become obvisously useless and removed. BUG=webrtc:5565 R=åsapersson Committed: https://crrev.com/13deaad1bd644157f242043d053eb30a3324b4b9 Cr-Commit-Position: refs/heads/master@{#12881}

Patch Set 1 #

Patch Set 2 : includes adjusted #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -30 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_receiver.cc View 1 4 chunks +6 lines, -8 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/rtcp_sender.cc View 1 4 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/tmmbr_help.h View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/tmmbr_help.cc View 6 chunks +0 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
åsapersson
lgtm
4 years, 7 months ago (2016-05-24 13:33:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959013003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959013003/20001
4 years, 7 months ago (2016-05-24 14:30:20 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-05-24 16:31:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1959013003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1959013003/20001
4 years, 7 months ago (2016-05-24 20:20:11 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-24 20:25:32 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 20:25:41 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/13deaad1bd644157f242043d053eb30a3324b4b9
Cr-Commit-Position: refs/heads/master@{#12881}

Powered by Google App Engine
This is Rietveld 408576698