Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Side by Side Diff: webrtc/video/encoder_state_feedback_unittest.cc

Issue 1958113003: Remove SendPacer from ViEEncoder and make sure SendPacer starts at a valid bitrate (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Removed initial bitrate from PacedSender. Updated unittests. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "webrtc/video/encoder_state_feedback.h" 11 #include "webrtc/video/encoder_state_feedback.h"
12 12
13 #include "testing/gmock/include/gmock/gmock.h" 13 #include "testing/gmock/include/gmock/gmock.h"
14 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
15 #include "webrtc/modules/pacing/packet_router.h"
16 #include "webrtc/modules/bitrate_controller/include/bitrate_controller.h"
17 #include "webrtc/modules/utility/include/mock/mock_process_thread.h" 15 #include "webrtc/modules/utility/include/mock/mock_process_thread.h"
18 #include "webrtc/video/vie_encoder.h" 16 #include "webrtc/video/vie_encoder.h"
19 17
20 using ::testing::NiceMock; 18 using ::testing::NiceMock;
21 19
22 namespace webrtc { 20 namespace webrtc {
23 21
24 class MockVieEncoder : public ViEEncoder { 22 class MockVieEncoder : public ViEEncoder {
25 public: 23 public:
26 explicit MockVieEncoder(ProcessThread* process_thread, PacedSender* pacer) 24 explicit MockVieEncoder(ProcessThread* process_thread)
27 : ViEEncoder(1, 25 : ViEEncoder(1, process_thread, nullptr, nullptr) {}
28 process_thread,
29 nullptr,
30 nullptr,
31 nullptr,
32 pacer) {}
33 ~MockVieEncoder() {} 26 ~MockVieEncoder() {}
34 27
35 MOCK_METHOD1(OnReceivedIntraFrameRequest, void(size_t)); 28 MOCK_METHOD1(OnReceivedIntraFrameRequest, void(size_t));
36 MOCK_METHOD1(OnReceivedSLI, void(uint8_t picture_id)); 29 MOCK_METHOD1(OnReceivedSLI, void(uint8_t picture_id));
37 MOCK_METHOD1(OnReceivedRPSI, void(uint64_t picture_id)); 30 MOCK_METHOD1(OnReceivedRPSI, void(uint64_t picture_id));
38 }; 31 };
39 32
40 class VieKeyRequestTest : public ::testing::Test { 33 class VieKeyRequestTest : public ::testing::Test {
41 public: 34 public:
42 VieKeyRequestTest() 35 VieKeyRequestTest()
43 : pacer_(Clock::GetRealTimeClock(), 36 : encoder_(&process_thread_),
44 &router_,
45 BitrateController::kDefaultStartBitrateKbps,
46 PacedSender::kDefaultPaceMultiplier *
47 BitrateController::kDefaultStartBitrateKbps,
48 0),
49 encoder_(&process_thread_, &pacer_),
50 simulated_clock_(123456789), 37 simulated_clock_(123456789),
51 encoder_state_feedback_( 38 encoder_state_feedback_(
52 &simulated_clock_, 39 &simulated_clock_,
53 std::vector<uint32_t>(1, VieKeyRequestTest::kSsrc), 40 std::vector<uint32_t>(1, VieKeyRequestTest::kSsrc),
54 &encoder_) {} 41 &encoder_) {}
55 42
56 protected: 43 protected:
57 const uint32_t kSsrc = 1234; 44 const uint32_t kSsrc = 1234;
58 NiceMock<MockProcessThread> process_thread_; 45 NiceMock<MockProcessThread> process_thread_;
59 PacketRouter router_;
60 PacedSender pacer_;
61 MockVieEncoder encoder_; 46 MockVieEncoder encoder_;
62 SimulatedClock simulated_clock_; 47 SimulatedClock simulated_clock_;
63 EncoderStateFeedback encoder_state_feedback_; 48 EncoderStateFeedback encoder_state_feedback_;
64 }; 49 };
65 50
66 TEST_F(VieKeyRequestTest, CreateAndTriggerRequests) { 51 TEST_F(VieKeyRequestTest, CreateAndTriggerRequests) {
67 EXPECT_CALL(encoder_, OnReceivedIntraFrameRequest(0)).Times(1); 52 EXPECT_CALL(encoder_, OnReceivedIntraFrameRequest(0)).Times(1);
68 encoder_state_feedback_.OnReceivedIntraFrameRequest(kSsrc); 53 encoder_state_feedback_.OnReceivedIntraFrameRequest(kSsrc);
69 54
70 const uint8_t sli_picture_id = 3; 55 const uint8_t sli_picture_id = 3;
(...skipping 13 matching lines...) Expand all
84 encoder_state_feedback_.OnReceivedIntraFrameRequest(kSsrc); 69 encoder_state_feedback_.OnReceivedIntraFrameRequest(kSsrc);
85 70
86 EXPECT_CALL(encoder_, OnReceivedIntraFrameRequest(0)).Times(1); 71 EXPECT_CALL(encoder_, OnReceivedIntraFrameRequest(0)).Times(1);
87 simulated_clock_.AdvanceTimeMilliseconds(300); 72 simulated_clock_.AdvanceTimeMilliseconds(300);
88 encoder_state_feedback_.OnReceivedIntraFrameRequest(kSsrc); 73 encoder_state_feedback_.OnReceivedIntraFrameRequest(kSsrc);
89 encoder_state_feedback_.OnReceivedIntraFrameRequest(kSsrc); 74 encoder_state_feedback_.OnReceivedIntraFrameRequest(kSsrc);
90 encoder_state_feedback_.OnReceivedIntraFrameRequest(kSsrc); 75 encoder_state_feedback_.OnReceivedIntraFrameRequest(kSsrc);
91 } 76 }
92 77
93 } // namespace webrtc 78 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/remote_bitrate_estimator/test/packet_sender.cc ('k') | webrtc/video/video_send_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698