Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: webrtc/voice_engine/channel_proxy.cc

Issue 1955363003: Configure VoE NACK through AudioSendStream::Config. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: misc Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 27 matching lines...) Expand all
38 } 38 }
39 39
40 void ChannelProxy::SetRTCP_CNAME(const std::string& c_name) { 40 void ChannelProxy::SetRTCP_CNAME(const std::string& c_name) {
41 RTC_DCHECK(thread_checker_.CalledOnValidThread()); 41 RTC_DCHECK(thread_checker_.CalledOnValidThread());
42 // Note: VoERTP_RTCP::SetRTCP_CNAME() accepts a char[256] array. 42 // Note: VoERTP_RTCP::SetRTCP_CNAME() accepts a char[256] array.
43 std::string c_name_limited = c_name.substr(0, 255); 43 std::string c_name_limited = c_name.substr(0, 255);
44 int error = channel()->SetRTCP_CNAME(c_name_limited.c_str()); 44 int error = channel()->SetRTCP_CNAME(c_name_limited.c_str());
45 RTC_DCHECK_EQ(0, error); 45 RTC_DCHECK_EQ(0, error);
46 } 46 }
47 47
48 void ChannelProxy::SetNACKStatus(bool enable, int max_packets) {
49 RTC_DCHECK(thread_checker_.CalledOnValidThread());
50 channel()->SetNACKStatus(enable, max_packets);
51 }
52
48 void ChannelProxy::SetSendAbsoluteSenderTimeStatus(bool enable, int id) { 53 void ChannelProxy::SetSendAbsoluteSenderTimeStatus(bool enable, int id) {
49 RTC_DCHECK(thread_checker_.CalledOnValidThread()); 54 RTC_DCHECK(thread_checker_.CalledOnValidThread());
50 int error = channel()->SetSendAbsoluteSenderTimeStatus(enable, id); 55 int error = channel()->SetSendAbsoluteSenderTimeStatus(enable, id);
51 RTC_DCHECK_EQ(0, error); 56 RTC_DCHECK_EQ(0, error);
52 } 57 }
53 58
54 void ChannelProxy::SetSendAudioLevelIndicationStatus(bool enable, int id) { 59 void ChannelProxy::SetSendAudioLevelIndicationStatus(bool enable, int id) {
55 RTC_DCHECK(thread_checker_.CalledOnValidThread()); 60 RTC_DCHECK(thread_checker_.CalledOnValidThread());
56 int error = channel()->SetSendAudioLevelIndicationStatus(enable, id); 61 int error = channel()->SetSendAudioLevelIndicationStatus(enable, id);
57 RTC_DCHECK_EQ(0, error); 62 RTC_DCHECK_EQ(0, error);
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
181 return channel()->ReceivedRTCPPacket(packet, length) == 0; 186 return channel()->ReceivedRTCPPacket(packet, length) == 0;
182 } 187 }
183 188
184 Channel* ChannelProxy::channel() const { 189 Channel* ChannelProxy::channel() const {
185 RTC_DCHECK(channel_owner_.channel()); 190 RTC_DCHECK(channel_owner_.channel());
186 return channel_owner_.channel(); 191 return channel_owner_.channel();
187 } 192 }
188 193
189 } // namespace voe 194 } // namespace voe
190 } // namespace webrtc 195 } // namespace webrtc
OLDNEW
« webrtc/media/engine/webrtcvoiceengine_unittest.cc ('K') | « webrtc/voice_engine/channel_proxy.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698