Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 7 months ago by AlexG Modified:
4 years, 7 months ago Reviewers:
wzh, pbos-webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com Base URL:
https://chromium.googlesource.com/external/webrtc@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionTune QP threshold for HW codecs.
Lower down bad thresholds a bit to avoid staying
at 720p resolution at 300 - 500 kbps.
R=wzh@webrtc.org
Committed: https://crrev.com/fac23f00efca1e8f9fc58294dfc9d6ffcc83f344
Cr-Commit-Position: refs/heads/master@{#12633}
Patch Set 1 #
Created: 4 years, 7 months ago
Messages
Total messages: 13 (5 generated)
glaznev@webrtc.org changed reviewers: + wzh@webrtc.org
PTAL
lgtm
The CQ bit was checked by glaznev@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954433002/1
Description was changed from ========== Tune QP threshold for HW codecs. Lower down bad thresholds a bit to avoid staying at 720p resolution at 300 - 500 kbps. ========== to ========== Tune QP threshold for HW codecs. Lower down bad thresholds a bit to avoid staying at 720p resolution at 300 - 500 kbps. R=wzh@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/fac23f00efca1e8f9fc58294d... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as fac23f00efca1e8f9fc58294dfc9d6ffcc83f344 (presubmit successful).
Message was sent while issue was closed.
Description was changed from ========== Tune QP threshold for HW codecs. Lower down bad thresholds a bit to avoid staying at 720p resolution at 300 - 500 kbps. R=wzh@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/fac23f00efca1e8f9fc58294d... ========== to ========== Tune QP threshold for HW codecs. Lower down bad thresholds a bit to avoid staying at 720p resolution at 300 - 500 kbps. R=wzh@webrtc.org Committed: https://crrev.com/fac23f00efca1e8f9fc58294dfc9d6ffcc83f344 Cr-Commit-Position: refs/heads/master@{#12633} ==========
Message was sent while issue was closed.
pbos@webrtc.org changed reviewers: + pbos@webrtc.org
Message was sent while issue was closed.
Alex please CC me on these changes. We don't want the thresholds to diverge again for hardware vs. software.
Message was sent while issue was closed.
On 2016/05/11 10:04:34, pbos-webrtc wrote: > Alex please CC me on these changes. We don't want the thresholds to diverge > again for hardware vs. software. Similarly if you are making changes in androidmediaencder_jni.cc pelase add me as reviewer https://codereview.webrtc.org/1954433002/
Message was sent while issue was closed.
On 2016/05/11 17:06:06, AlexG wrote: > On 2016/05/11 10:04:34, pbos-webrtc wrote: > > Alex please CC me on these changes. We don't want the thresholds to diverge > > again for hardware vs. software. > > Similarly if you are making changes in androidmediaencder_jni.cc pelase add me > as reviewer > https://codereview.webrtc.org/1954433002/ Sure, will do. (and decoder etc.)
Message was sent while issue was closed.
On 2016/05/11 17:06:06, AlexG wrote: > On 2016/05/11 10:04:34, pbos-webrtc wrote: > > Alex please CC me on these changes. We don't want the thresholds to diverge > > again for hardware vs. software. > > Similarly if you are making changes in androidmediaencder_jni.cc pelase add me > as reviewer > https://codereview.webrtc.org/1954433002/ Sure, will do. (and decoder etc.) |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
