Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1954433002: Tune QP threshold for HW codecs. (Closed)

Created:
4 years, 7 months ago by AlexG
Modified:
4 years, 7 months ago
Reviewers:
wzh, pbos-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Tune QP threshold for HW codecs. Lower down bad thresholds a bit to avoid staying at 720p resolution at 300 - 500 kbps. R=wzh@webrtc.org Committed: https://crrev.com/fac23f00efca1e8f9fc58294dfc9d6ffcc83f344 Cr-Commit-Position: refs/heads/master@{#12633}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M webrtc/api/java/jni/androidmediaencoder_jni.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
AlexG
PTAL
4 years, 7 months ago (2016-05-04 18:10:03 UTC) #2
wzh
lgtm
4 years, 7 months ago (2016-05-04 18:11:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1954433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1954433002/1
4 years, 7 months ago (2016-05-04 18:12:43 UTC) #5
AlexG
Committed patchset #1 (id:1) manually as fac23f00efca1e8f9fc58294dfc9d6ffcc83f344 (presubmit successful).
4 years, 7 months ago (2016-05-04 19:58:39 UTC) #7
pbos-webrtc
Alex please CC me on these changes. We don't want the thresholds to diverge again ...
4 years, 7 months ago (2016-05-11 10:04:34 UTC) #10
AlexG
On 2016/05/11 10:04:34, pbos-webrtc wrote: > Alex please CC me on these changes. We don't ...
4 years, 7 months ago (2016-05-11 17:06:06 UTC) #11
pbos-webrtc
On 2016/05/11 17:06:06, AlexG wrote: > On 2016/05/11 10:04:34, pbos-webrtc wrote: > > Alex please ...
4 years, 7 months ago (2016-05-11 17:11:15 UTC) #12
pbos-webrtc
4 years, 7 months ago (2016-05-11 17:11:18 UTC) #13
Message was sent while issue was closed.
On 2016/05/11 17:06:06, AlexG wrote:
> On 2016/05/11 10:04:34, pbos-webrtc wrote:
> > Alex please CC me on these changes. We don't want the thresholds to diverge
> > again for hardware vs. software.
> 
> Similarly if you are making changes in androidmediaencder_jni.cc pelase add me
> as reviewer
> https://codereview.webrtc.org/1954433002/

Sure, will do. (and decoder etc.)

Powered by Google App Engine
This is Rietveld 408576698