Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 1951833002: Set rtcp_send_transport for AudioReceiveStreams. This was forgotten in https://codereview.webrtc.or… (Closed)

Created:
4 years, 7 months ago by the sun
Modified:
4 years, 7 months ago
Reviewers:
mflodman
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Set rtcp_send_transport for AudioReceiveStreams. This was forgotten in https://codereview.webrtc.org/1909333002/. BUG=webrtc:4690, webrtc:5079, webrtc:5762 Committed: https://crrev.com/31fec4048248364070fca8a3ff554c9caa5b1b81 Cr-Commit-Position: refs/heads/master@{#12640}

Patch Set 1 #

Patch Set 2 : Android gunit idiosyncracies #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -2 lines) Patch
M webrtc/media/engine/webrtcvoiceengine.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/media/engine/webrtcvoiceengine_unittest.cc View 1 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
the sun
4 years, 7 months ago (2016-05-04 11:09:12 UTC) #3
mflodman
Thanks for fixing, LGTM!
4 years, 7 months ago (2016-05-06 07:36:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951833002/1
4 years, 7 months ago (2016-05-06 07:36:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_x64_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x64_dbg/builds/3740) android_dbg on tryserver.webrtc (JOB_FAILED, ...
4 years, 7 months ago (2016-05-06 07:39:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1951833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1951833002/20001
4 years, 7 months ago (2016-05-06 08:13:54 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-06 09:13:16 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 09:13:30 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/31fec4048248364070fca8a3ff554c9caa5b1b81
Cr-Commit-Position: refs/heads/master@{#12640}

Powered by Google App Engine
This is Rietveld 408576698