Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1950973002: Revert of Use RC_TIMESTAMP_MODE for OpenH264. (Closed)

Created:
4 years, 7 months ago by pbos-webrtc
Modified:
4 years, 7 months ago
Reviewers:
hbos
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Use RC_TIMESTAMP_MODE for OpenH264. (patchset #1 id:1 of https://codereview.webrtc.org/1945763002/ ) Reason for revert: Previous mode aligns with other encoders, and RC_TIMESTAMP_MODE might have issues with no frames for several seconds. Original issue's description: > Use RC_TIMESTAMP_MODE for OpenH264. > > Performs rate control based on timestamp deltas instead of announced > frame rate. > > BUG=webrtc:5855 > R=hbos@webrtc.org > > Committed: https://crrev.com/c4deee49a3ec42b7fe83c82f750539b36aae1d3f > Cr-Commit-Position: refs/heads/master@{#12611} TBR=hbos@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5855 Committed: https://crrev.com/b49ac78c71d3dfa24a8a3877ca800c9593a484ee Cr-Commit-Position: refs/heads/master@{#12629}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M webrtc/modules/video_coding/codecs/h264/h264_encoder_impl.cc View 2 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
pbos-webrtc
Created Revert of Use RC_TIMESTAMP_MODE for OpenH264.
4 years, 7 months ago (2016-05-04 14:17:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950973002/1
4 years, 7 months ago (2016-05-04 14:17:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 14:17:56 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 14:18:07 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b49ac78c71d3dfa24a8a3877ca800c9593a484ee
Cr-Commit-Position: refs/heads/master@{#12629}

Powered by Google App Engine
This is Rietveld 408576698