Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(870)

Issue 1949803004: Moved the functionality in aec_core_internal.h into other files (Closed)

Created:
4 years, 7 months ago by peah-webrtc
Modified:
4 years, 7 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@ObjectifyEchoCancellation_CL
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Moved the functionality in aec_core_internal.h into other files. The purpose of this CL is to simplify upcoming AEC algorithm changes. The changes should be bitexact. The presubmit was bypassed due to a presubmit complaint about usage of short instead of int16_t which will be addressed in upcoming CLs. BUG=webrtc:5298, webrtc:5201 NOPRESUBMIT=true Committed: https://crrev.com/e687f7816c9e6b7e374d62a4d44ce4ee14a49168 Cr-Commit-Position: refs/heads/master@{#12662}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Corrected a bad merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -7 lines) Patch
M webrtc/modules/audio_processing/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core.h View 1 2 3 chunks +180 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_mips.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_neon.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A webrtc/modules/audio_processing/aec/aec_core_optimized_methods.h View 1 2 1 chunk +79 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/aec/aec_core_sse2.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/audio_processing.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (12 generated)
peah-webrtc
4 years, 7 months ago (2016-05-04 08:23:01 UTC) #3
hlundin-webrtc
lgtm
4 years, 7 months ago (2016-05-09 08:26:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949803004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949803004/20001
4 years, 7 months ago (2016-05-09 09:32:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios32_sim_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_dbg/builds/7303) ios_arm64_dbg on tryserver.webrtc (JOB_FAILED, ...
4 years, 7 months ago (2016-05-09 09:33:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949803004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949803004/40001
4 years, 7 months ago (2016-05-09 09:56:38 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/5375)
4 years, 7 months ago (2016-05-09 10:01:57 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949803004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949803004/40001
4 years, 7 months ago (2016-05-09 10:32:14 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-09 10:57:38 UTC) #19
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 10:57:45 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e687f7816c9e6b7e374d62a4d44ce4ee14a49168
Cr-Commit-Position: refs/heads/master@{#12662}

Powered by Google App Engine
This is Rietveld 408576698