webrtc/modules/audio_coding/neteq/neteq_impl.cc - Issue 1949533002: WIP: Move the creation of AudioCodecFactory into PeerConnectionFactory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/neteq/neteq_impl.cc

Issue 1949533002: WIP: Move the creation of AudioCodecFactory into PeerConnectionFactory. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Retained Channel API by adding overloads; also add intended AudioReceiveStream API Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/audio_coding/neteq/neteq.cc ('K') | « webrtc/modules/audio_coding/neteq/neteq_impl.h ('k') | webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc » ('j') | webrtc/voice_engine/include/voe_base.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/neteq/neteq_impl.cc

diff --git a/webrtc/modules/audio_coding/neteq/neteq_impl.cc b/webrtc/modules/audio_coding/neteq/neteq_impl.cc

index b4ba650fefb3e2066401104b2b6a5b5b1b630530..06506904793f6356986266c93388325d72fc98a5 100644

--- a/webrtc/modules/audio_coding/neteq/neteq_impl.cc

+++ b/webrtc/modules/audio_coding/neteq/neteq_impl.cc

@@ -22,7 +22,6 @@

#include "webrtc/base/trace_event.h"

#include "webrtc/common_audio/signal_processing/include/signal_processing_library.h"

#include "webrtc/modules/audio_coding/codecs/audio_decoder.h"

-#include "webrtc/modules/audio_coding/codecs/builtin_audio_decoder_factory.h"

#include "webrtc/modules/audio_coding/neteq/accelerate.h"

#include "webrtc/modules/audio_coding/neteq/background_noise.h"

#include "webrtc/modules/audio_coding/neteq/buffer_level_filter.h"

@@ -55,10 +54,12 @@

namespace webrtc {

-NetEqImpl::Dependencies::Dependencies(const NetEq::Config& config)

+NetEqImpl::Dependencies::Dependencies(

+ const NetEq::Config& config,

+ std::shared_ptr<AudioDecoderFactory> decoder_factory)

: tick_timer(new TickTimer),

buffer_level_filter(new BufferLevelFilter),

- decoder_database(new DecoderDatabase(CreateBuiltinAudioDecoderFactory())),

+ decoder_database(new DecoderDatabase(std::move(decoder_factory))),

delay_peak_detector(new DelayPeakDetector(tick_timer.get())),

delay_manager(new DelayManager(config.max_packets_in_buffer,

delay_peak_detector.get(),