webrtc/modules/audio_coding/neteq/include/neteq.h - Issue 1949533002: WIP: Move the creation of AudioCodecFactory into PeerConnectionFactory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/neteq/include/neteq.h

Issue 1949533002: WIP: Move the creation of AudioCodecFactory into PeerConnectionFactory. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Retained Channel API by adding overloads; also add intended AudioReceiveStream API Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/media/engine/webrtcvoiceengine_unittest.cc ('K') | « webrtc/modules/audio_coding/neteq/decoder_database.cc ('k') | webrtc/modules/audio_coding/neteq/mock/mock_decoder_database.h » ('j') | webrtc/modules/audio_coding/neteq/mock/mock_decoder_database.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/neteq/include/neteq.h

diff --git a/webrtc/modules/audio_coding/neteq/include/neteq.h b/webrtc/modules/audio_coding/neteq/include/neteq.h

index 89b0c543244536084d15bf4df08db51eebda6509..d83513a2d869a5570dad22351e844145da3afe96 100644

--- a/webrtc/modules/audio_coding/neteq/include/neteq.h

+++ b/webrtc/modules/audio_coding/neteq/include/neteq.h

@@ -26,6 +26,7 @@ namespace webrtc {

// Forward declarations.

class AudioFrame;

struct WebRtcRTPHeader;

+class AudioDecoderFactory;

kwiberg-webrtc 2016/05/17 13:33:48 Why not just include the header instead?

ossu 2016/05/17 14:25:35 I ... I don't know. Either way works, I guess.

struct NetEqNetworkStatistics {

uint16_t current_buffer_size_ms; // Current jitter buffer size in ms.

@@ -132,7 +133,9 @@ class NetEq {

// Creates a new NetEq object, with parameters set in |config|. The |config|

// object will only have to be valid for the duration of the call to this

// method.

- static NetEq* Create(const NetEq::Config& config);

+ static NetEq* Create(

+ const NetEq::Config& config,

+ std::shared_ptr<AudioDecoderFactory> decoder_factory);

virtual ~NetEq() {}