Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Unified Diff: webrtc/media/engine/webrtcvoiceengine.h

Issue 1949533002: WIP: Move the creation of AudioCodecFactory into PeerConnectionFactory. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Retained Channel API by adding overloads; also add intended AudioReceiveStream API Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/media/engine/webrtcvoiceengine.h
diff --git a/webrtc/media/engine/webrtcvoiceengine.h b/webrtc/media/engine/webrtcvoiceengine.h
index 1cc550430435b4dedadd20144c0ce0c109119be0..8a1a034538b08fba566ec29fe4dc1ffdaa005562 100644
--- a/webrtc/media/engine/webrtcvoiceengine.h
+++ b/webrtc/media/engine/webrtcvoiceengine.h
@@ -46,9 +46,14 @@ class WebRtcVoiceEngine final : public webrtc::TraceCallback {
// Exposed for the WVoE/MC unit test.
static bool ToCodecInst(const AudioCodec& in, webrtc::CodecInst* out);
- explicit WebRtcVoiceEngine(webrtc::AudioDeviceModule* adm);
+ explicit WebRtcVoiceEngine(
+ webrtc::AudioDeviceModule* adm,
+ std::shared_ptr<webrtc::AudioDecoderFactory> decoder_factory);
// Dependency injection for testing.
- WebRtcVoiceEngine(webrtc::AudioDeviceModule* adm, VoEWrapper* voe_wrapper);
+ WebRtcVoiceEngine(
+ webrtc::AudioDeviceModule* adm,
+ std::shared_ptr<webrtc::AudioDecoderFactory> decoder_factory,
+ VoEWrapper* voe_wrapper);
~WebRtcVoiceEngine() override;
rtc::scoped_refptr<webrtc::AudioState> GetAudioState() const;
@@ -111,6 +116,7 @@ class WebRtcVoiceEngine final : public webrtc::TraceCallback {
// The audio device manager.
rtc::scoped_refptr<webrtc::AudioDeviceModule> adm_;
+ std::shared_ptr<webrtc::AudioDecoderFactory> decoder_factory_;
// The primary instance of WebRtc VoiceEngine.
std::unique_ptr<VoEWrapper> voe_wrapper_;
rtc::scoped_refptr<webrtc::AudioState> audio_state_;

Powered by Google App Engine
This is Rietveld 408576698