webrtc/media/engine/webrtcmediaengine.h - Issue 1949533002: WIP: Move the creation of AudioCodecFactory into PeerConnectionFactory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/engine/webrtcmediaengine.h

Issue 1949533002: WIP: Move the creation of AudioCodecFactory into PeerConnectionFactory. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Retained Channel API by adding overloads; also add intended AudioReceiveStream API Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/audio/audio_receive_stream.cc ('K') | « webrtc/media/engine/nullwebrtcvideoengine_unittest.cc ('k') | webrtc/media/engine/webrtcmediaengine.cc » ('j') | webrtc/media/engine/webrtcvoiceengine_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/media/engine/webrtcmediaengine.h

diff --git a/webrtc/media/engine/webrtcmediaengine.h b/webrtc/media/engine/webrtcmediaengine.h

index 19b7d222f2ea9c548b160e6fc2b7baac31c5fed6..c5c0d33587112c9c604757766b9d6b2ce7eee6f1 100644

--- a/webrtc/media/engine/webrtcmediaengine.h

+++ b/webrtc/media/engine/webrtcmediaengine.h

@@ -31,8 +31,9 @@ class WebRtcMediaEngineFactory {

public:

static MediaEngineInterface* Create(

webrtc::AudioDeviceModule* adm,

- WebRtcVideoEncoderFactory* encoder_factory,

- WebRtcVideoDecoderFactory* decoder_factory);

+ std::shared_ptr<webrtc::AudioDecoderFactory> audio_decoder_factory,

+ WebRtcVideoEncoderFactory* video_encoder_factory,

+ WebRtcVideoDecoderFactory* video_decoder_factory);

};

// Verify that extension IDs are within 1-byte extension range and are not