Chromium Code Reviews| Index: webrtc/audio/audio_receive_stream.cc |
| diff --git a/webrtc/audio/audio_receive_stream.cc b/webrtc/audio/audio_receive_stream.cc |
| index f984c7fb2096f9c293137a65311e9d4b94e04fcd..6461403ffb4357adb49a90182ae7a485b5c9d7d3 100644 |
| --- a/webrtc/audio/audio_receive_stream.cc |
| +++ b/webrtc/audio/audio_receive_stream.cc |
| @@ -94,6 +94,14 @@ AudioReceiveStream::AudioReceiveStream( |
| channel_proxy_ = voe_impl->GetChannelProxy(config_.voe_channel_id); |
| channel_proxy_->SetLocalSSRC(config.rtp.local_ssrc); |
| + // This is where we'd like to set the decoder factory to use. However, since |
| + // it needs to be included when constructing Channel, we cannot do that until |
| + // we're able to move Channel ownership into the Audio{Send,Receive}Streams. |
| + // The best we can do is check that we're not trying to use two different |
| + // factories using the different interfaces. |
| + RTC_CHECK(config.decoder_factory && |
| + config.decoder_factory == channel_proxy_->GetAudioDecoderFactory()); |
|
kwiberg-webrtc
2016/05/17 13:33:48
Better to use two separate check calls. That way,
ossu
2016/05/17 14:25:35
Good point!
|
| + |
| channel_proxy_->RegisterExternalTransport(config.rtcp_send_transport); |
| for (const auto& extension : config.rtp.extensions) { |