Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1948473002: Android GlDrawer: Add frame size as argument to draw functions (Closed)

Created:
4 years, 7 months ago by magjed_webrtc
Modified:
4 years, 7 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Android GlDrawer: Add frame size as argument to draw functions BUG=b/28544933 Committed: https://crrev.com/71af75dc3ca8516017dca9de2ebe582145ecad14 Cr-Commit-Position: refs/heads/master@{#12623}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -21 lines) Patch
M webrtc/api/androidtests/src/org/webrtc/GlRectDrawerTest.java View 1 4 chunks +8 lines, -4 lines 0 comments Download
M webrtc/api/androidtests/src/org/webrtc/SurfaceTextureHelperTest.java View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/api/java/android/org/webrtc/GlRectDrawer.java View 3 chunks +9 lines, -6 lines 0 comments Download
M webrtc/api/java/android/org/webrtc/RendererCommon.java View 1 chunk +6 lines, -3 lines 0 comments Download
M webrtc/api/java/android/org/webrtc/SurfaceViewRenderer.java View 1 chunk +4 lines, -2 lines 0 comments Download
M webrtc/api/java/android/org/webrtc/VideoRendererGui.java View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/api/java/src/org/webrtc/MediaCodecVideoEncoder.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
magjed1
Alex - please take a look.
4 years, 7 months ago (2016-05-03 13:20:17 UTC) #4
AlexG
lgtm
4 years, 7 months ago (2016-05-03 17:12:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1948473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1948473002/20001
4 years, 7 months ago (2016-05-04 07:52:12 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-04 09:02:14 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/71af75dc3ca8516017dca9de2ebe582145ecad14 Cr-Commit-Position: refs/heads/master@{#12623}
4 years, 7 months ago (2016-05-04 09:02:23 UTC) #13
ivoc
4 years, 7 months ago (2016-05-04 13:50:05 UTC) #14
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/1950953002/ by ivoc@webrtc.org.

The reason for reverting is: Causes errors on Google3 import..

Powered by Google App Engine
This is Rietveld 408576698