Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1947853002: Revert of Remove SendPacer from ViEEncoder (Closed)

Created:
4 years, 7 months ago by perkj_webrtc
Modified:
4 years, 7 months ago
Reviewers:
stefan-webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhuangzesen_agora.io, zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Remove SendPacer from ViEEncoder (patchset #13 id:240001 of https://codereview.webrtc.org/1917793002/ ) Reason for revert: Fails in the waterfall here: https://build.chromium.org/p/client.webrtc/builders/Win32%20Debug/builds/7832/steps/rtc_media_unittests/logs/stdio Original issue's description: > Remove SendPacer from ViEEncoder > > This CL moves the logic where the ViEEncoder pause if the pacer is full to the BitrateController. If the queue is full, the controller reports a bitrate of zero to Call (and BitrateAllocator) > > BUG=webrtc:5687 > > Committed: https://crrev.com/857c5ccdb56e4c94196f7c6227abd5993c95abe2 > Cr-Commit-Position: refs/heads/master@{#12620} TBR=stefan@webrtc.org,mflodman@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5687 Committed: https://crrev.com/825eb58d59940a4c3c9837595c4b3b07059c93ca Cr-Commit-Position: refs/heads/master@{#12621}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+374 lines, -553 lines) Patch
M webrtc/audio/audio_receive_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/audio/audio_send_stream_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/call/bitrate_allocator.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/call/bitrate_allocator.cc View 3 chunks +13 lines, -11 lines 0 comments Download
M webrtc/call/bitrate_allocator_unittest.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M webrtc/call/call.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_impl.h View 3 chunks +7 lines, -10 lines 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_impl.cc View 3 chunks +5 lines, -13 lines 0 comments Download
M webrtc/modules/bitrate_controller/bitrate_controller_unittest.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M webrtc/modules/bitrate_controller/include/bitrate_controller.h View 4 chunks +1 line, -13 lines 0 comments Download
M webrtc/modules/bitrate_controller/include/mock/mock_bitrate_controller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M webrtc/modules/congestion_controller/congestion_controller.cc View 5 chunks +18 lines, -69 lines 0 comments Download
D webrtc/modules/congestion_controller/congestion_controller_unittest.cc View 1 chunk +0 lines, -111 lines 0 comments Download
M webrtc/modules/congestion_controller/include/congestion_controller.h View 5 chunks +7 lines, -35 lines 0 comments Download
M webrtc/modules/congestion_controller/include/mock/mock_congestion_controller.h View 1 chunk +4 lines, -10 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/pacing/mock/mock_paced_sender.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/pacing/paced_sender.h View 6 chunks +17 lines, -21 lines 0 comments Download
M webrtc/modules/pacing/paced_sender.cc View 7 chunks +28 lines, -37 lines 0 comments Download
M webrtc/modules/pacing/paced_sender_unittest.cc View 23 chunks +215 lines, -169 lines 0 comments Download
M webrtc/modules/pacing/packet_router.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/packet_sender.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/remote_bitrate_estimator/test/packet_sender.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M webrtc/video/encoder_state_feedback_unittest.cc View 2 chunks +10 lines, -3 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 2 chunks +4 lines, -8 lines 0 comments Download
M webrtc/video/vie_encoder.h View 2 chunks +6 lines, -1 line 0 comments Download
M webrtc/video/vie_encoder.cc View 4 chunks +12 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
perkj_webrtc
Created Revert of Remove SendPacer from ViEEncoder
4 years, 7 months ago (2016-05-04 08:07:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947853002/1
4 years, 7 months ago (2016-05-04 08:07:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 08:08:10 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 08:08:23 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/825eb58d59940a4c3c9837595c4b3b07059c93ca
Cr-Commit-Position: refs/heads/master@{#12621}

Powered by Google App Engine
This is Rietveld 408576698