Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 1947743004: Removed the file echo_cancellation_internal.h and moved the file content to echo_cancellation.h. (Closed)

Created:
4 years, 7 months ago by peah-webrtc
Modified:
4 years, 7 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@NewLogging2_CL
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removed the file echo_cancellation_internal.h and moved the file content to echo_cancellation.h. The purpose of this CL is to simplify upcoming AEC algorithm changes. The changes should be bitexact. BUG=webrtc:5298, webrtc:5201 Committed: https://crrev.com/44c8a373a52a5d20ed5470204a9324885dfe5f6c Cr-Commit-Position: refs/heads/master@{#12638}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Updated buildfiles with the removed file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -77 lines) Patch
M webrtc/modules/audio_processing/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/aec/echo_cancellation.h View 2 chunks +54 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/aec/echo_cancellation.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/modules/audio_processing/aec/echo_cancellation_internal.h View 1 chunk +0 lines, -73 lines 0 comments Download
M webrtc/modules/audio_processing/aec/system_delay_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_processing/audio_processing.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (10 generated)
peah-webrtc
4 years, 7 months ago (2016-05-04 07:18:30 UTC) #2
hlundin-webrtc
lgtm
4 years, 7 months ago (2016-05-04 10:01:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947743004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947743004/40001
4 years, 7 months ago (2016-05-05 18:59:42 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_x64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/14466)
4 years, 7 months ago (2016-05-05 19:02:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947743004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947743004/60001
4 years, 7 months ago (2016-05-05 19:29:32 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 7 months ago (2016-05-05 20:34:34 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 20:34:44 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/44c8a373a52a5d20ed5470204a9324885dfe5f6c
Cr-Commit-Position: refs/heads/master@{#12638}

Powered by Google App Engine
This is Rietveld 408576698