Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 1947483002: Removing SpatialAudio test code (Closed)

Created:
4 years, 7 months ago by hlundin-webrtc
Modified:
4 years, 7 months ago
Reviewers:
kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removing SpatialAudio test code The code has not been dead for almost four years (since https://webrtc-codereview.appspot.com/636006). NOTRY=True Committed: https://crrev.com/c8fe991a3df41ee3f6e9a9154426a6ee46619977 Cr-Commit-Position: refs/heads/master@{#12610}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -245 lines) Patch
D webrtc/modules/audio_coding/test/SpatialAudio.h View 1 chunk +0 lines, -48 lines 0 comments Download
D webrtc/modules/audio_coding/test/SpatialAudio.cc View 1 chunk +0 lines, -196 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
hlundin-webrtc
4 years, 7 months ago (2016-05-03 13:19:15 UTC) #2
kwiberg-webrtc
lgtm!
4 years, 7 months ago (2016-05-03 13:36:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947483002/1
4 years, 7 months ago (2016-05-03 15:37:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 15:40:10 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-03 15:40:16 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c8fe991a3df41ee3f6e9a9154426a6ee46619977
Cr-Commit-Position: refs/heads/master@{#12610}

Powered by Google App Engine
This is Rietveld 408576698