Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1947073002: Reland of Android GlDrawer: Add frame size as argument to draw functions (Closed)

Created:
4 years, 7 months ago by ivoc
Modified:
4 years, 7 months ago
Reviewers:
AlexG, magjed_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Android GlDrawer: Add frame size as argument to draw functions (patchset #1 id:1 of https://codereview.webrtc.org/1950953002/ ) Reason for revert: I was too quick to judge, this CL does not cause the problem. Original issue's description: > Revert of Android GlDrawer: Add frame size as argument to draw functions (patchset #2 id:20001 of https://codereview.webrtc.org/1948473002/ ) > > Reason for revert: > Causes errors on Google3 import. > > Original issue's description: > > Android GlDrawer: Add frame size as argument to draw functions > > > > BUG=b/28544933 > > > > Committed: https://crrev.com/71af75dc3ca8516017dca9de2ebe582145ecad14 > > Cr-Commit-Position: refs/heads/master@{#12623} > > TBR=glaznev@webrtc.org,magjed@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=b/28544933 > > Committed: https://crrev.com/172683173dd84a72659ad494962245445eb2a353 > Cr-Commit-Position: refs/heads/master@{#12627} TBR=glaznev@webrtc.org,magjed@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=b/28544933 Committed: https://crrev.com/1aa435c6db3d489554af49942a50ac42e63650de Cr-Commit-Position: refs/heads/master@{#12628}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -21 lines) Patch
M webrtc/api/androidtests/src/org/webrtc/GlRectDrawerTest.java View 4 chunks +8 lines, -4 lines 0 comments Download
M webrtc/api/androidtests/src/org/webrtc/SurfaceTextureHelperTest.java View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/api/java/android/org/webrtc/GlRectDrawer.java View 3 chunks +9 lines, -6 lines 0 comments Download
M webrtc/api/java/android/org/webrtc/RendererCommon.java View 1 chunk +6 lines, -3 lines 0 comments Download
M webrtc/api/java/android/org/webrtc/SurfaceViewRenderer.java View 1 chunk +4 lines, -2 lines 0 comments Download
M webrtc/api/java/android/org/webrtc/VideoRendererGui.java View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/api/java/src/org/webrtc/MediaCodecVideoEncoder.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
ivoc
Created Reland of Android GlDrawer: Add frame size as argument to draw functions
4 years, 7 months ago (2016-05-04 14:14:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1947073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1947073002/1
4 years, 7 months ago (2016-05-04 14:14:08 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 14:14:17 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 14:14:29 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1aa435c6db3d489554af49942a50ac42e63650de
Cr-Commit-Position: refs/heads/master@{#12628}

Powered by Google App Engine
This is Rietveld 408576698