Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1130)

Issue 1946873003: Run "git cl format --full" on a pair of files with ancient formatting (Closed)

Created:
4 years, 7 months ago by kwiberg-webrtc
Modified:
4 years, 7 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, tommi
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Run "git cl format --full" on a pair of files with ancient formatting Committed: https://crrev.com/73987c9932b2b6a49bda467a448d428119e933f5 Cr-Commit-Position: refs/heads/master@{#12625}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -83 lines) Patch
M webrtc/modules/utility/source/coder.h View 1 chunk +31 lines, -29 lines 2 comments Download
M webrtc/modules/utility/source/coder.cc View 2 chunks +43 lines, -54 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
kwiberg-webrtc
Making good on an old promise to Tommi.
4 years, 7 months ago (2016-05-04 10:28:15 UTC) #2
perkj_webrtc
https://codereview.webrtc.org/1946873003/diff/1/webrtc/modules/utility/source/coder.h File webrtc/modules/utility/source/coder.h (right): https://codereview.webrtc.org/1946873003/diff/1/webrtc/modules/utility/source/coder.h#newcode54 webrtc/modules/utility/source/coder.h:54: std::unique_ptr<AudioCodingModule> _acm; fix the naming while your are at ...
4 years, 7 months ago (2016-05-04 10:43:55 UTC) #3
kwiberg-webrtc
https://codereview.webrtc.org/1946873003/diff/1/webrtc/modules/utility/source/coder.h File webrtc/modules/utility/source/coder.h (right): https://codereview.webrtc.org/1946873003/diff/1/webrtc/modules/utility/source/coder.h#newcode54 webrtc/modules/utility/source/coder.h:54: std::unique_ptr<AudioCodingModule> _acm; On 2016/05/04 10:43:55, perkj_webrtc wrote: > fix ...
4 years, 7 months ago (2016-05-04 10:49:04 UTC) #4
perkj_webrtc
lgtm
4 years, 7 months ago (2016-05-04 12:08:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1946873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1946873003/1
4 years, 7 months ago (2016-05-04 12:08:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 12:12:23 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 12:12:31 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/73987c9932b2b6a49bda467a448d428119e933f5
Cr-Commit-Position: refs/heads/master@{#12625}

Powered by Google App Engine
This is Rietveld 408576698