Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: webrtc/modules/pacing/bitrate_prober_unittest.cc

Issue 1946173002: Bitrate prober now keep track of probing cluster id. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Removed commented code. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include <limits> 11 #include <limits>
12 12
13 #include "testing/gtest/include/gtest/gtest.h" 13 #include "testing/gtest/include/gtest/gtest.h"
14 #include "webrtc/modules/pacing/bitrate_prober.h" 14 #include "webrtc/modules/pacing/bitrate_prober.h"
15 15
16 namespace webrtc { 16 namespace webrtc {
17 17
18 TEST(BitrateProberTest, VerifyStatesAndTimeBetweenProbes) { 18 TEST(BitrateProberTest, VerifyStatesAndTimeBetweenProbes) {
19 BitrateProber prober; 19 BitrateProber prober;
20 EXPECT_FALSE(prober.IsProbing()); 20 EXPECT_FALSE(prober.IsProbing());
21 int64_t now_ms = 0; 21 int64_t now_ms = 0;
22 EXPECT_EQ(-1, prober.TimeUntilNextProbe(now_ms)); 22 EXPECT_EQ(-1, prober.TimeUntilNextProbe(now_ms));
23 23
24 prober.SetEnabled(true); 24 prober.SetEnabled(true);
25 EXPECT_FALSE(prober.IsProbing()); 25 EXPECT_FALSE(prober.IsProbing());
26 EXPECT_EQ(-1, prober.CurrentClusterId());
26 27
27 prober.OnIncomingPacket(300000, 1000, now_ms); 28 prober.OnIncomingPacket(300000, 1000, now_ms);
28 EXPECT_TRUE(prober.IsProbing()); 29 EXPECT_TRUE(prober.IsProbing());
30 EXPECT_EQ(0, prober.CurrentClusterId());
29 31
30 // First packet should probe as soon as possible. 32 // First packet should probe as soon as possible.
31 EXPECT_EQ(0, prober.TimeUntilNextProbe(now_ms)); 33 EXPECT_EQ(0, prober.TimeUntilNextProbe(now_ms));
32 prober.PacketSent(now_ms, 1000); 34 prober.PacketSent(now_ms, 1000);
33 35
34 for (int i = 0; i < 5; ++i) { 36 for (int i = 0; i < 5; ++i) {
35 EXPECT_EQ(8, prober.TimeUntilNextProbe(now_ms)); 37 EXPECT_EQ(8, prober.TimeUntilNextProbe(now_ms));
36 now_ms += 4; 38 now_ms += 4;
37 EXPECT_EQ(4, prober.TimeUntilNextProbe(now_ms)); 39 EXPECT_EQ(4, prober.TimeUntilNextProbe(now_ms));
38 now_ms += 4; 40 now_ms += 4;
39 EXPECT_EQ(0, prober.TimeUntilNextProbe(now_ms)); 41 EXPECT_EQ(0, prober.TimeUntilNextProbe(now_ms));
42 EXPECT_EQ(0, prober.CurrentClusterId());
40 prober.PacketSent(now_ms, 1000); 43 prober.PacketSent(now_ms, 1000);
41 } 44 }
42 for (int i = 0; i < 5; ++i) { 45 for (int i = 0; i < 5; ++i) {
43 EXPECT_EQ(4, prober.TimeUntilNextProbe(now_ms)); 46 EXPECT_EQ(4, prober.TimeUntilNextProbe(now_ms));
44 now_ms += 4; 47 now_ms += 4;
45 EXPECT_EQ(0, prober.TimeUntilNextProbe(now_ms)); 48 EXPECT_EQ(0, prober.TimeUntilNextProbe(now_ms));
49 EXPECT_EQ(1, prober.CurrentClusterId());
46 prober.PacketSent(now_ms, 1000); 50 prober.PacketSent(now_ms, 1000);
47 } 51 }
48 52
53 EXPECT_EQ(-1, prober.CurrentClusterId());
49 EXPECT_EQ(-1, prober.TimeUntilNextProbe(now_ms)); 54 EXPECT_EQ(-1, prober.TimeUntilNextProbe(now_ms));
50 EXPECT_FALSE(prober.IsProbing()); 55 EXPECT_FALSE(prober.IsProbing());
51 } 56 }
52 57
53 TEST(BitrateProberTest, DoesntProbeWithoutRecentPackets) { 58 TEST(BitrateProberTest, DoesntProbeWithoutRecentPackets) {
54 BitrateProber prober; 59 BitrateProber prober;
55 EXPECT_FALSE(prober.IsProbing()); 60 EXPECT_FALSE(prober.IsProbing());
56 int64_t now_ms = 0; 61 int64_t now_ms = 0;
57 EXPECT_EQ(-1, prober.TimeUntilNextProbe(now_ms)); 62 EXPECT_EQ(-1, prober.TimeUntilNextProbe(now_ms));
58 63
(...skipping 23 matching lines...) Expand all
82 TEST(BitrateProberTest, DoesntInitializeProbingForSmallPackets) { 87 TEST(BitrateProberTest, DoesntInitializeProbingForSmallPackets) {
83 BitrateProber prober; 88 BitrateProber prober;
84 prober.SetEnabled(true); 89 prober.SetEnabled(true);
85 EXPECT_FALSE(prober.IsProbing()); 90 EXPECT_FALSE(prober.IsProbing());
86 91
87 prober.OnIncomingPacket(300000, 100, 0); 92 prober.OnIncomingPacket(300000, 100, 0);
88 EXPECT_FALSE(prober.IsProbing()); 93 EXPECT_FALSE(prober.IsProbing());
89 } 94 }
90 95
91 } // namespace webrtc 96 } // namespace webrtc
OLDNEW
« webrtc/modules/pacing/bitrate_prober.cc ('K') | « webrtc/modules/pacing/bitrate_prober.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698