Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: webrtc/modules/pacing/bitrate_prober.h

Issue 1946173002: Bitrate prober now keep track of probing cluster id. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Removed commented code. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MODULES_PACING_BITRATE_PROBER_H_ 11 #ifndef WEBRTC_MODULES_PACING_BITRATE_PROBER_H_
12 #define WEBRTC_MODULES_PACING_BITRATE_PROBER_H_ 12 #define WEBRTC_MODULES_PACING_BITRATE_PROBER_H_
13 13
14 #include <cstddef> 14 #include <cstddef>
15 #include <list> 15 #include <list>
16 #include <queue>
16 17
17 #include "webrtc/typedefs.h" 18 #include "webrtc/typedefs.h"
18 19
19 namespace webrtc { 20 namespace webrtc {
20 21
21 // Note that this class isn't thread-safe by itself and therefore relies 22 // Note that this class isn't thread-safe by itself and therefore relies
22 // on being protected by the caller. 23 // on being protected by the caller.
23 class BitrateProber { 24 class BitrateProber {
24 public: 25 public:
25 BitrateProber(); 26 BitrateProber();
26 27
27 void SetEnabled(bool enable); 28 void SetEnabled(bool enable);
28 29
29 // Returns true if the prober is in a probing session, i.e., it currently 30 // Returns true if the prober is in a probing session, i.e., it currently
30 // wants packets to be sent out according to the time returned by 31 // wants packets to be sent out according to the time returned by
31 // TimeUntilNextProbe(). 32 // TimeUntilNextProbe().
32 bool IsProbing() const; 33 bool IsProbing() const;
33 34
34 // Initializes a new probing session if the prober is allowed to probe. Does 35 // Initializes a new probing session if the prober is allowed to probe. Does
35 // not initialize the prober unless the packet size is large enough to probe 36 // not initialize the prober unless the packet size is large enough to probe
36 // with. 37 // with.
37 void OnIncomingPacket(int bitrate_bps, size_t packet_size, int64_t now_ms); 38 void OnIncomingPacket(int bitrate_bps, size_t packet_size, int64_t now_ms);
38 39
39 // Returns the number of milliseconds until the next packet should be sent to 40 // Returns the number of milliseconds until the next packet should be sent to
40 // get accurate probing. 41 // get accurate probing.
41 int TimeUntilNextProbe(int64_t now_ms); 42 int TimeUntilNextProbe(int64_t now_ms);
42 43
44 // Which cluster that is currently being used for probing.
45 int CurrentClusterId() const;
46
43 // Returns the number of bytes that the prober recommends for the next probe 47 // Returns the number of bytes that the prober recommends for the next probe
44 // packet. 48 // packet.
45 size_t RecommendedPacketSize() const; 49 size_t RecommendedPacketSize() const;
46 50
47 // Called to report to the prober that a packet has been sent, which helps the 51 // Called to report to the prober that a packet has been sent, which helps the
48 // prober know when to move to the next packet in a probe. 52 // prober know when to move to the next packet in a probe.
49 void PacketSent(int64_t now_ms, size_t packet_size); 53 void PacketSent(int64_t now_ms, size_t packet_size);
50 54
51 private: 55 private:
52 enum ProbingState { kDisabled, kAllowedToProbe, kProbing, kWait }; 56 enum ProbingState { kDisabled, kAllowedToProbe, kProbing, kWait };
53 57
58 struct ProbeCluster {
59 uint8_t max_probe_packets = 0;
60 uint8_t sent_probe_packets = 0;
stefan-webrtc 2016/05/04 09:42:35 int for these too?
philipel 2016/05/04 10:36:32 Done.
61 int probe_bitrate = 0;
stefan-webrtc 2016/05/04 09:42:35 probe_bitrate_bps
philipel 2016/05/04 10:36:32 Done.
62 int id = -1;
63 };
64
54 ProbingState probing_state_; 65 ProbingState probing_state_;
55 // Probe bitrate per packet. These are used to compute the delta relative to 66 // Probe bitrate per packet. These are used to compute the delta relative to
56 // the previous probe packet based on the size and time when that packet was 67 // the previous probe packet based on the size and time when that packet was
57 // sent. 68 // sent.
58 std::list<int> probe_bitrates_; 69 std::queue<ProbeCluster> clusters_;
59 size_t packet_size_last_send_; 70 size_t packet_size_last_send_;
60 int64_t time_last_send_ms_; 71 int64_t time_last_send_ms_;
72 int cluster_id_;
61 }; 73 };
62 } // namespace webrtc 74 } // namespace webrtc
63 #endif // WEBRTC_MODULES_PACING_BITRATE_PROBER_H_ 75 #endif // WEBRTC_MODULES_PACING_BITRATE_PROBER_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/modules/pacing/bitrate_prober.cc » ('j') | webrtc/modules/pacing/bitrate_prober.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698