Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1167)

Side by Side Diff: webrtc/modules/audio_coding/codecs/mock/mock_audio_encoder.h

Issue 1946133002: Revert of Enable -Winconsistent-missing-override flag. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MODULES_AUDIO_CODING_CODECS_MOCK_MOCK_AUDIO_ENCODER_H_ 11 #ifndef WEBRTC_MODULES_AUDIO_CODING_CODECS_MOCK_MOCK_AUDIO_ENCODER_H_
12 #define WEBRTC_MODULES_AUDIO_CODING_CODECS_MOCK_MOCK_AUDIO_ENCODER_H_ 12 #define WEBRTC_MODULES_AUDIO_CODING_CODECS_MOCK_MOCK_AUDIO_ENCODER_H_
13 13
14 #include <string> 14 #include <string>
15 15
16 #include "webrtc/base/array_view.h" 16 #include "webrtc/base/array_view.h"
17 #include "webrtc/modules/audio_coding/codecs/audio_encoder.h" 17 #include "webrtc/modules/audio_coding/codecs/audio_encoder.h"
18 18
19 #include "testing/gmock/include/gmock/gmock.h" 19 #include "testing/gmock/include/gmock/gmock.h"
20 20
21 namespace webrtc { 21 namespace webrtc {
22 22
23 class MockAudioEncoder : public AudioEncoder { 23 class MockAudioEncoder : public AudioEncoder {
24 public: 24 public:
25 // TODO(nisse): Valid overrides commented out, because the gmock 25 ~MockAudioEncoder() override { Die(); }
26 // methods don't use any override declarations, and we want to avoid
27 // warnings from -Winconsistent-missing-override. See
28 // http://crbug.com/428099.
29 ~MockAudioEncoder() /* override */ { Die(); }
30 MOCK_METHOD0(Die, void()); 26 MOCK_METHOD0(Die, void());
31 MOCK_METHOD1(Mark, void(std::string desc)); 27 MOCK_METHOD1(Mark, void(std::string desc));
32 MOCK_CONST_METHOD0(SampleRateHz, int()); 28 MOCK_CONST_METHOD0(SampleRateHz, int());
33 MOCK_CONST_METHOD0(NumChannels, size_t()); 29 MOCK_CONST_METHOD0(NumChannels, size_t());
34 MOCK_CONST_METHOD0(RtpTimestampRateHz, int()); 30 MOCK_CONST_METHOD0(RtpTimestampRateHz, int());
35 MOCK_CONST_METHOD0(Num10MsFramesInNextPacket, size_t()); 31 MOCK_CONST_METHOD0(Num10MsFramesInNextPacket, size_t());
36 MOCK_CONST_METHOD0(Max10MsFramesInAPacket, size_t()); 32 MOCK_CONST_METHOD0(Max10MsFramesInAPacket, size_t());
37 MOCK_CONST_METHOD0(GetTargetBitrate, int()); 33 MOCK_CONST_METHOD0(GetTargetBitrate, int());
38 MOCK_METHOD0(Reset, void()); 34 MOCK_METHOD0(Reset, void());
39 MOCK_METHOD1(SetFec, bool(bool enable)); 35 MOCK_METHOD1(SetFec, bool(bool enable));
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 86
91 private: 87 private:
92 AudioEncoder::EncodedInfo info_; 88 AudioEncoder::EncodedInfo info_;
93 rtc::ArrayView<const uint8_t> payload_; 89 rtc::ArrayView<const uint8_t> payload_;
94 }; 90 };
95 }; 91 };
96 92
97 } // namespace webrtc 93 } // namespace webrtc
98 94
99 #endif // WEBRTC_MODULES_AUDIO_CODING_CODECS_MOCK_MOCK_AUDIO_ENCODER_H_ 95 #endif // WEBRTC_MODULES_AUDIO_CODING_CODECS_MOCK_MOCK_AUDIO_ENCODER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698